Ok, no worries, for now this is ok El dc., 17 juny 2015 a les 11:34, Romain Manni-Bucau (<[email protected]>) va escriure:
> 2015-06-17 11:27 GMT+02:00 Alex Soto <[email protected]>: > > > Yes, but as you said consistent with jaxb tree but what's happening if > you > > want to use it as simple POJO for dynamic registration? Well it was only > a > > suggestion, of course it is not blocker. > > > > > sure but that's the common pattern for collections. Setters are fine for > single valued fields IMO, optional for others. > > A builder would be better than a setter IMO. Think David started few things > about it butwe never finished the API AFAIK. > > > > > > > > El dc., 17 juny 2015 a les 11:25, Romain Manni-Bucau (< > > [email protected]>) > > va escriure: > > > > > Yes and no. It is javadoc-ed and consistent in our "jaxb tree". > > > Le 17 juin 2015 10:19, "Alex Soto" <[email protected]> a écrit : > > > > > > > Yes but it is a bit antinatural if all other methods follows the > > > > getter/setter, maybe a setter and an append methid in case of > > properties > > > > could have more sense. > > > > > > > > El dc., 17 juny 2015 a les 11:16, Romain Manni-Bucau (< > > > > [email protected]>) > > > > va escriure: > > > > > > > > > Not sure i got it. You use getProperties to mutate it > > > > > Le 17 juin 2015 10:01, "Alex Soto" <[email protected]> a écrit : > > > > > > > > > > > Hi, currently I am developing an application which I am > registering > > > > > > dynamically resources using Assembler class. > > > > > > > > > > > > I have seen that AbstractService has a field called properties > that > > > you > > > > > can > > > > > > only get information from it but not set it. All other fields has > > its > > > > own > > > > > > getter/setter except this one. I think that if there is nothing > > > against > > > > > it > > > > > > it should have a setter too so I can dynamically set properties > > too. > > > > > > > > > > > > The class is here: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/config/sys/AbstractService.java > > > > > > > > > > > > I can provide a PR if you agree. > > > > > > > > > > > > Alex. > > > > > > > > > > > > > > > > > > > > >
