yes yank the profile if not usable and if no one should use it to avoid mistakes
-- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 31, 2018 at 10:23 AM, Mark Struberg <strub...@yahoo.de.invalid> wrote: > > Then we should at least add a README? > Or at least document that profile in the pom. > > LieGrue, > strub > > > > > Am 31.01.2018 um 09:59 schrieb Romain Manni-Bucau <rmannibu...@gmail.com > >: > > > > 2018-01-31 9:34 GMT+01:00 Mark Struberg <strub...@yahoo.de.invalid>: > > > >> Yes I thought something similar when trashing 2 hours to try to get the > >> JAXB generator running. > >> Just to figure it might be broken beyond repair... > >> Thanks that you at least confirm this view and spare me further > >> investigation. > >> > >> There are 2 options on the table > >> > >> 1.) Do a quick hack and add the <trim/> support directly in the code > >> > > +1 > > > >> 2.) Invest more time and fix the JAXB source generator setup > >> > > No point today to do it. Can be worse keeping it as a comment somewhere > for > > future specs if needed but not for existing one IMHO. > > > >> > >> I'm tempted to go 1. > >> But of course I'm happy if someone finds a bit time to fix the generator > >> setup. > >> David, you did this initially. Is it worth it and can you free up some > >> time for it? > >> > >> > >> LieGrue, > >> strub > >> > >> > >>> Am 31.01.2018 um 09:20 schrieb Romain Manni-Bucau < > rmannibu...@gmail.com > >>> : > >>> > >>> Hi Mark, > >>> > >>> For simple updates like that I tend to update the sax parser manually > >>> (that's what we did for JSF since most of the model is not handled by > >> tomee > >>> anyway). > >>> For CDI we are supposed to still use JAXB (since there can be a lot of > >>> beans.xml): > >>> https://github.com/apache/tomee/blob/master/container/ > >> openejb-core/src/main/java/org/apache/openejb/config/ > >> ReadDescriptors.java#L681 > >>> > >>> > >>> > >>> Romain Manni-Bucau > >>> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >>> <https://rmannibucau.metawerx.net/> | Old Blog > >>> <http://rmannibucau.wordpress.com> | Github <https://github.com/ > >> rmannibucau> | > >>> LinkedIn <https://www.linkedin.com/in/rmannibucau> > >>> > >>> 2018-01-31 8:17 GMT+01:00 Mark Struberg <strub...@yahoo.de.invalid>: > >>> > >>>> Hi folks! > >>>> > >>>> I've come down to just 18 failing tests in tck/cdi-embedded. > >>>> Most of them are EE related (missing privileges exceptions etc) > >>>> > >>>> There is one left with the CDI integration: <trim/> support. > >>>> This needs a change in the beans.xml schema. > >>>> I've added the changes and moved to container/openejb-jee/src/ > >>>> main/resources/META-INF/schema/beans_2_0.xsd > >>>> > >>>> But now I totally fail to generate the JAXB sources. > >>>> I've found the maven profile to start the generator, but it simply > fails > >>>> with an Exception. > >>>> > >>>> Anyone able to help out? > >>>> > >>>> The work is done in fb_tomee8 > >>>> > >>>> Btw, I also tried the attached patch to move to valid urls at least... > >>>> > >>>> > >>>> LieGrue, > >>>> strub > >>>> > >>>> > >>>> > >> > >> > >
