PR looks good now to me - we need to have the war vs tomee-maven-plugin assembly discussion in another thread so it doesn't block this particula topic.
Happy to merge it next week or if anyone else wants to have a look and do it just go :). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> 2018-03-10 8:03 GMT+01:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > > > Le 9 mars 2018 23:21, "Roberto Cortez" <radcor...@yahoo.com.invalid> a > écrit : > > > Hi, > New update to the PR. Let me know if that is better. > I still believe we should have org.apache.geronimo.confi > g.configsource.SystemPropertyConfigSource.copy = false as default, since > that is the behaviour the TCK expects. > > > Point is that it should be consistent with the real impl default. That > said it is not the default cause of TCK I think since it is more costly to > check it each time so can need a refinement here but independent from tomee > integration which is the whole point. > > Will check the pr update tmr, thanks for the hard work. > > > Cheers,Roberto On Wednesday, March 7, 2018, 8:07:04 AM GMT, Romain > Manni-Bucau <rmannibu...@gmail.com> wrote: > > 2018-03-07 6:00 GMT+01:00 Gurkan Erdogdu <gurkanerdo...@yahoo.com.inval > id>: > > > Hi all>>>>Yep, as mentionned no issue to have a new distro ;).Right > > decision, TomEE is the best reasonable place to have MP profile. We also > > need to have only MP profile of TomEE (TomEE Micro with only have MP > > nothing else). > > > > Depends, we already have hammock which is a great MP "only" server so tomee > WP+MP can be beneficial for end users and avoid duplication @asf. Was just > my raw thought on that. > > > > > > CheersGurkan > > > > On Tuesday, March 6, 2018, 12:32:03 AM GMT+3, Romain Manni-Bucau < > > rmannibu...@gmail.com> wrote: > > > > Le 5 mars 2018 22:07, "Jonathan Gallimore" < > jonathan.gallim...@gmail.com> > > a > > écrit : > > > > On Mon, Mar 5, 2018 at 9:03 PM, Romain Manni-Bucau < > rmannibu...@gmail.com> > > wrote: > > > > > > > > > > > Le 5 mars 2018 21:35, "Jonathan Gallimore" < > jonathan.gallim...@gmail.com > > > > > > a écrit : > > > > > > The name "MicroProfile" suggests an element of being small, so I'm not > > > sure why we'd only add this to our biggest distribution and no where > > else. > > > I've built the change (thanks for the help Roberto), and it adds <100KB > > to > > > the binary. I'd definitely add it to Plus and Plume, but I think we > > should > > > either add it web profile, or if we really don't want it in > WebProfile, I > > > see no harm in an extra flavour that is webprofile + microprofile. > > > > > > > > > Ok for plume and plus for me, please not to WP. > > > > > > > Would you be ok with the MP profile then? Seems like reasonable middle > > ground. Without that, folks who want "Micro"Profile features would be > > forced to use the biggest flavours. > > > > > > Yep, as mentionned no issue to have a new distro ;). > > > > > > > > > > > > Open point: should it be switchable to off even if provided in case it > > > breaks apps? > > > > > > > I'm ok with that. > > > > Jon > > > > >
