There is a VOTE so I believe we need to close it or move it forward. The PR is mine and therefor it's time for me to vote and speak. As I put some efforts to create this PR and make all the TCK tests to pass, I'm in favor of merging obviously.
I have submitted to a conference and I'll be speaking about TomEE and JWT in a month. That would be a good way to challenge our integration and consider the "where the code should go after" later. MP-JWT discussions started again, and some of the work will probably have to go away because it will be invalid. In this PR, there is also a fix for the Security context propagation that whatever we do with the JWT code, we'll need to get this fixed. When I joined Apache, I started in TomEE and there was some motivation, help, smile and it got us here. We did mistakes, merged bad code, good code, but overall, the result is positive in my opinion. So maybe the code is not perfect, maybe we'll want to extract it into another library, but for now it works. So here is my +1 Now, there is a stop sign here that we need to resolve if we want this to be merged unless I'm mistaken. What can I do to resolve the problems so the -1 can turn into a +1? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Mar 23, 2018 at 10:17 PM, Gurkan Erdogdu < gurkanerdo...@yahoo.com.invalid> wrote: > Hi David+1 to merge in TomEE. Regards.Gurkan > On Monday, March 19, 2018, 3:02:20 AM GMT+3, David Blevins < > david.blev...@gmail.com> wrote: > > Jean-Louis has put a PR up for discussion for JWT Support in TomEE. > > - https://github.com/apache/tomee/pull/123 > > There are 35 commits spanning 27 days of work. It's been reviewed by Andy > and Rudy. One a committer and one a contributor, which is great for us. > > There's an open question as to where the code should live in its final > state: TomEE or Geronimo. This conversation doesn't seem conclusive after > 12 days. It's ok for us not to agree, but we should have more votes so > there is a clear outcome and we are acting as a community to our best > ability. > > Vote: Merge Pull Request 123? > > +1 Yes, let's do it > +-0 Abstain > -1 No, don't put this code in TomEE > > > Out of respect for the conversation, this is not a vote of where the code > will live in its final state. This is just a decision to merge or not. It > would give the users something they can try, which can be updated by a > future PR if the code does eventually move. > > > -David > >
