Most important thing I think is to say what code you'll be working on before 
you invest the time, just to make sure someone else is not also cleaning the 
same code (duplication).

If two PRs come in at the same time and one has a JIRA "Cleaning openejb-ejbd 
module" and the other has no JIRA or a generic "cleaning everything" JIRA, I'm 
taking the more specific one.  "hands off all code everywhere, I'm cleaning it" 
is too broad of a scope.

I think you could probably even make all the jiras now for every module and 
then more people could help.


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Dec 3, 2018, at 11:12 AM, Hayri Cicek <[email protected]> wrote:
> 
> Hi everybody,
> 
> I have a question:
> 
> I created JIRA ticket TOMEE-2314 and I don't want to have big PR's is it
> okej to make multiple PR for that ticket or should I create a ticket per
> branch/PR I work on, the thing is that I'm trying to make usage of diamond
> operator, final variables/parameters and naming conventions..( If you guys
> want me to contribute with something else I can maybe do that instead of
> doing "clean up" 😄, ) I don't mind doing this 😄
> 
> 
> / Hayri Cicek

Reply via email to