Okej then I know, contributing to Open Source is new to me :) and better to ask ,
Yes I had forgotten to update my setting :( but now it's configured :) Den mån 3 dec. 2018 kl 21:21 skrev David Blevins <[email protected]>: > Side note, your git client is configured to not have your email in it. It > has "Hayri Cicek <[email protected]>" > > So unfortunately you're not showing up here: > > - https://github.com/apache/tomee/graphs/contributors > > I don't know if there's anyway to fix the old commits, but definitely > update your settings for the new commits so you can get proper credit. > > > -- > David Blevins > http://twitter.com/dblevins > http://www.tomitribe.com > > > On Dec 3, 2018, at 11:12 AM, Hayri Cicek <[email protected]> wrote: > > > > Hi everybody, > > > > I have a question: > > > > I created JIRA ticket TOMEE-2314 and I don't want to have big PR's is it > > okej to make multiple PR for that ticket or should I create a ticket per > > branch/PR I work on, the thing is that I'm trying to make usage of > diamond > > operator, final variables/parameters and naming conventions..( If you > guys > > want me to contribute with something else I can maybe do that instead of > > doing "clean up" 😄, ) I don't mind doing this 😄 > > > > > > / Hayri Cicek > >
