rmannibucau commented on a change in pull request #767: URL: https://github.com/apache/tomee/pull/767#discussion_r596599296
########## File path: container/openejb-junit5/pom.xml ########## @@ -0,0 +1,90 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>container</artifactId> + <groupId>org.apache.tomee</groupId> + <version>8.0.7-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>openejb-junit5</artifactId> + <packaging>jar</packaging> + <name>TomEE :: Container :: JUnit 5</name> + + <properties> + <tomee.build.name>${project.groupId}.container.junit5</tomee.build.name> + <netbeans.hint.license>openejb</netbeans.hint.license> + <jacocoArgLine/> + </properties> + + <dependencies> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>openejb-core</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-api</artifactId> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-engine</artifactId> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.openejb.itests</groupId> + <artifactId>failover-ejb</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <version>${surefire.junit5.version}</version> + <configuration> + <childDelegation>true</childDelegation> + <reuseForks>false</reuseForks> + <forkCount>1</forkCount> + <argLine> + ${jacocoArgLine} + -enableassertions + </argLine> + <workingDirectory>${project.basedir}/target</workingDirectory> + <systemPropertyVariables> + <openejb.home>${project.basedir}/target/test-classes</openejb.home> + </systemPropertyVariables> + <excludes> Review comment: an excluded test is a test to delete ;) joke apart, use N executions to ensure all tests run in the build. ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerExtensionBase.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.junit.jupiter.api.TestInstance; +import org.junit.jupiter.api.extension.ExtensionContext; +import org.junit.platform.commons.util.AnnotationUtils; + +import java.util.Optional; + +public abstract class ApplicationComposerExtensionBase { + + boolean isPerClassLifecycle(final ExtensionContext context) { + return isPerTestInstanceLifecycle(context, TestInstance.Lifecycle.PER_CLASS); + } + + boolean isPerMethodLifecycle(final ExtensionContext context) { + return isPerTestInstanceLifecycle(context, TestInstance.Lifecycle.PER_METHOD); + } + + boolean isPerTestInstanceLifecycle(final ExtensionContext context, TestInstance.Lifecycle lifecycle) { + return context.getTestInstanceLifecycle() + .map(it -> it.equals(lifecycle)) + .orElse(false); + } + + protected boolean isPerEach(final ExtensionContext context) { + return checkMode(context, ExtensionMode.PER_EACH); + } + + boolean isPerAll(final ExtensionContext context) { + return checkMode(context, ExtensionMode.PER_ALL); + } + + boolean isPerJvm(final ExtensionContext context) { + return checkMode(context, ExtensionMode.PER_JVM); + } + + boolean isPerDefault(final ExtensionContext context) { + return checkMode(context, ExtensionMode.AUTO); + } + + boolean checkMode(final ExtensionContext context, ExtensionMode extensionMode ) { + return extensionMode == getModeFromAnnotation(context); + } + + ExtensionMode getModeFromAnnotation(final ExtensionContext context) { + if (context.getTestClass().isPresent()) { Review comment: ``` return context.getTestClass() .flatMap(test -> AnnotationUtils.findAnnotation(test, RunWithApplicationComposer.class)) .map(RunWithApplicationComposer::mode) .orElse(ExtensionMode.AUTO); ``` Overall optional.get() should almost never be used ;) ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerPerXYExtensionBase.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.apache.openejb.OpenEJBRuntimeException; +import org.apache.openejb.testing.ApplicationComposers; +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; +import org.junit.jupiter.api.extension.TestInstances; + +import java.util.List; + +abstract class ApplicationComposerPerXYExtensionBase extends ApplicationComposerExtensionBase implements BeforeAllCallback, AfterAllCallback, BeforeEachCallback, AfterEachCallback { + + private static final ExtensionContext.Namespace NAMESPACE = ExtensionContext.Namespace.create(ApplicationComposerPerXYExtensionBase.class.getName()); + + private final Object[] modules; + + public ApplicationComposerPerXYExtensionBase() { + this((Object[]) null); + } + + public ApplicationComposerPerXYExtensionBase(Object... modules) { + this.modules = modules; + } + + abstract void validate(ExtensionContext context); Review comment: I'd put it protected and not package scope, wdyt? ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerPerAllExtension.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.apache.openejb.OpenEJBRuntimeException; +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; + +public class ApplicationComposerPerAllExtension extends ApplicationComposerPerXYExtensionBase implements BeforeAllCallback, AfterAllCallback, BeforeEachCallback, AfterEachCallback { + + public ApplicationComposerPerAllExtension() { + this((Object[]) null); + } + + public ApplicationComposerPerAllExtension(Object... modules) { + super(modules); + } + + @Override + void validate(ExtensionContext context) { + if (isPerAll(context) && isPerMethodLifecycle(context)) { + //XXX: Might be possible to make this work - for now, we are going to throw something... + throw new OpenEJBRuntimeException("Cannot run PER_ALL in combination with TestInstance.Lifecycle.PER_METHOD."); Review comment: maybe just log a warning/multiline info log, it means the injections will be lost at test > 1 but for 1 test it is fine and for N > 1 tests it works if you use CDI.current() or InitialContext or pure client (http) to impl the test. ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerExtension.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.apache.openejb.OpenEJBRuntimeException; +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; + +public class ApplicationComposerExtension extends ApplicationComposerExtensionBase implements BeforeAllCallback, AfterAllCallback, BeforeEachCallback, AfterEachCallback { + + private static final ExtensionContext.Namespace NAMESPACE = ExtensionContext.Namespace.create(ApplicationComposerExtension.class.getName()); + + private final Object[] modules; + + public ApplicationComposerExtension() { + this((Object[]) null); + } + + public ApplicationComposerExtension(Object... modules) { + this.modules = modules; + } + + @Override + public void beforeAll(ExtensionContext context) throws Exception { + + if (!isPerJvm(context) && ApplicationComposerPerJVMExtension.isStarted()) { + //XXX: Future work: We might get it to work via a JVM singleton/lock, see https://github.com/apache/tomee/pull/767#discussion_r595343572 + throw new OpenEJBRuntimeException("Cannot run PER_JVM in combination with PER_ALL, PER_EACH or AUTO"); + } + + if (isPerJvm(context)) { + context.getStore(NAMESPACE).put(ApplicationComposerPerXYExtensionBase.class, new ApplicationComposerPerJVMExtension()); Review comment: if modules.length > 0 => throw it is unsupported, use -Dtomee.application etc ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/AfterReleaserBase.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.apache.openejb.testing.ApplicationComposers; +import org.junit.jupiter.api.extension.ExtensionContext; + +public abstract class AfterReleaserBase extends ApplicationComposerExtensionBase { + + private final ExtensionContext.Namespace namespace; + + AfterReleaserBase(ExtensionContext.Namespace namespace) { + this.namespace = namespace; + } + + void run(final ExtensionContext extensionContext) throws Exception { + doRelease(extensionContext); + } + + void doRelease(final ExtensionContext extensionContext) throws Exception { Review comment: shouldn't it be merged with run? don't think it is needed to split anymore, wdyt? ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerExtension.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.apache.openejb.OpenEJBRuntimeException; +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; + +public class ApplicationComposerExtension extends ApplicationComposerExtensionBase implements BeforeAllCallback, AfterAllCallback, BeforeEachCallback, AfterEachCallback { + + private static final ExtensionContext.Namespace NAMESPACE = ExtensionContext.Namespace.create(ApplicationComposerExtension.class.getName()); + + private final Object[] modules; + + public ApplicationComposerExtension() { + this((Object[]) null); + } + + public ApplicationComposerExtension(Object... modules) { + this.modules = modules; + } + + @Override + public void beforeAll(ExtensionContext context) throws Exception { + + if (!isPerJvm(context) && ApplicationComposerPerJVMExtension.isStarted()) { Review comment: let the delegate validate it in before all? the trick will be to make the validation work when this facade is not used too so each impl must validate the combinations (or the parent do it all) so the facade does not need any validation I think ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerPerJVMExtension.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.apache.openejb.OpenEJBRuntimeException; +import org.apache.openejb.testing.Classes; +import org.apache.openejb.testing.Component; +import org.apache.openejb.testing.Default; +import org.apache.openejb.testing.Jars; +import org.apache.openejb.testing.Module; +import org.apache.openejb.testing.SingleApplicationComposerBase; +import org.apache.xbean.finder.ClassFinder; +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; +import org.junit.jupiter.api.extension.TestInstances; + +import java.lang.annotation.Annotation; +import java.util.ArrayList; +import java.util.List; + +import static org.apache.openejb.util.Classes.ancestors; + +public class ApplicationComposerPerJVMExtension extends ApplicationComposerPerXYExtensionBase implements BeforeAllCallback, AfterAllCallback, BeforeEachCallback, AfterEachCallback { + + private static final SingleApplicationComposerBase BASE = new SingleApplicationComposerBase(); + + @Override + void validate(ExtensionContext context) { + if (!isPerJvm(context) && BASE.isStarted()) { + //XXX: Future work: We might get it to work via a JVM singleton/lock, see https://github.com/apache/tomee/pull/767#discussion_r595343572 + throw new OpenEJBRuntimeException("Cannot run PER_JVM in combination with PER_ALL, PER_EACH or AUTO"); + } + + Class<?> clazz = context.getTestClass() + .orElseThrow(() -> new OpenEJBRuntimeException("Could not obtain test class from extension context")); + + final List<Throwable> errors = new ArrayList<>(); + + ClassFinder classFinder = new ClassFinder(ancestors(clazz)); + + Class<? extends Annotation>[] toCheck = new Class[]{Component.class, Module.class, Classes.class, Default.class, Jars.class}; + + for (Class<? extends Annotation> annotation : toCheck) { + if (classFinder.isAnnotationPresent(annotation)) { + errors.add(new Exception("@" + annotation.getName() + " is not allowed with @Application in PER_JVM mode")); + } + } + + if (!errors.isEmpty()) { + throw new OpenEJBRuntimeException(errors.toString()); + } + } + + @Override + public void beforeAll(ExtensionContext context) throws Exception { + super.beforeAll(context); + + BASE.start(context.getTestClass().orElse(null)); + if (isPerClassLifecycle(context)) { + doInject(context); + } + } + + @Override + public void beforeEach(ExtensionContext context) throws Exception { + if (isPerMethodLifecycle(context)) { + doInject(context); + } + } + + private void doInject(final ExtensionContext extensionContext) { Review comment: this one should be the same for all cases, even global one, no? ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerPerEachExtension.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; + +public class ApplicationComposerPerEachExtension extends ApplicationComposerPerXYExtensionBase implements BeforeAllCallback, AfterAllCallback, BeforeEachCallback, AfterEachCallback { + + public ApplicationComposerPerEachExtension() { + this((Object[]) null); + } + + public ApplicationComposerPerEachExtension(Object... modules) { + super(modules); + } + + @Override + void validate(ExtensionContext context) { + //no-op + } + + @Override + public void afterAll(ExtensionContext context) throws Exception { + addAfterEachReleaser(context); Review comment: this one looks fishy, shouldnt it be in beforeEach? ########## File path: container/openejb-junit5/pom.xml ########## @@ -0,0 +1,90 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>container</artifactId> + <groupId>org.apache.tomee</groupId> + <version>8.0.7-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>openejb-junit5</artifactId> + <packaging>jar</packaging> + <name>TomEE :: Container :: JUnit 5</name> + + <properties> + <tomee.build.name>${project.groupId}.container.junit5</tomee.build.name> + <netbeans.hint.license>openejb</netbeans.hint.license> + <jacocoArgLine/> + </properties> + + <dependencies> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>openejb-core</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-api</artifactId> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-engine</artifactId> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.openejb.itests</groupId> + <artifactId>failover-ejb</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <version>${surefire.junit5.version}</version> Review comment: we should have a single surefire version for the full build IMHO ########## File path: container/openejb-junit5/src/main/java/org/apache/openejb/junit5/ApplicationComposerPerDefaultExtension.java ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.openejb.junit5; + +import org.junit.jupiter.api.extension.AfterAllCallback; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeAllCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; + +public class ApplicationComposerPerDefaultExtension extends ApplicationComposerPerXYExtensionBase implements BeforeAllCallback, AfterAllCallback, BeforeEachCallback, AfterEachCallback { + + public ApplicationComposerPerDefaultExtension() { + this((Object[]) null); + } + + public ApplicationComposerPerDefaultExtension(Object... modules) { + super(modules); + } + + @Override + void validate(ExtensionContext context) { Review comment: I suspect parent one can be empty by defaul tinstead of being abstract ########## File path: examples/junit5-application-composer/pom.xml ########## @@ -0,0 +1,120 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<!-- $Rev: 636494 $ $Date: 2008-03-12 21:24:02 +0100 (Wed, 12 Mar 2008) $ --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + <groupId>org.superbiz</groupId> + <artifactId>junit5-application-composer</artifactId> + <packaging>jar</packaging> + <version>8.0.7-SNAPSHOT</version> + <name>TomEE :: Examples :: JUnit 5 :: Application Composer</name> + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + </properties> + <build> + <defaultGoal>install</defaultGoal> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-compiler-plugin</artifactId> + <version>3.5.1</version> + <configuration> + <source>1.8</source> + <target>1.8</target> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <version>3.0.0-M5</version> + <configuration> + <argLine>-Djdk.attach.allowAttachSelf</argLine> + </configuration> + </plugin> + <plugin> Review comment: this one is not needed since the deployment is skipped by putting it locally IMHO ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
