Hi, yeah, such PRs are difficult to review by nature :)
Thanks for the effort to make it consistent and more clear! Personally, I am fine with the proposal. If we don't want to do the "big bang integration" approach, we can easily setup a CI job on jenkins (similar to our full build by simply cloning it) and compare the results with current master. The only thing we would need to do is to get the branch from Swell's fork and push it to a branch on the TomEE repo. Would take only a couple of minutes + 6-8 hours ci cycle time. Wdyt? Gruß Richard Am Mittwoch, dem 28.09.2022 um 16:25 +0200 schrieb Swell: > Hi everyone, > > The pom.xml of the project uses several properties to configure > dependencies. some of which not used anymore since switching from > geronimo > to smallrye. > > i've been working on removing orphan properties, renaming versions > props on > the same format whenever i was able. reorganizing a bit. > > the proposed PR became a little big bang with almost 100 poms > impacted, and > hard to review. > > the possible course of action would be collecting opinion here by > mail > before merging, see if it breaks and possibly fix afterward. > > Thanks for your time. > -- > Swell
smime.p7s
Description: S/MIME cryptographic signature
