We have some results from two runs, which are close in terms of failed test + they look similar to the ones on master ;-)
Looks like our last dependency update killed a few hundred tests. Gruß Richard Am Mittwoch, dem 28.09.2022 um 20:31 +0200 schrieb Swell: > Thanks for the CI job Richard ! > > while it builds i'll clean some props on my own branch using David > suggestions : > > removing api, tck, and impl prefixes and have separate props for > microprofile api and smallrye impl > > -- > Swell > > On Wed, 28 Sept 2022 at 20:21, Zowalla, Richard < > [email protected]> wrote: > > > Regarding CI: > > > > I just pushed Swell's branch as a branch named TOMEE-4053 to the > > TomEE > > main repo and we will get some CI results via > > https://ci-builds.apache.org/job/Tomee/job/TOMEE-4053/ soon (6-8h) > > ;-) > > > > I have no hard opinion regarding version.foo vs version.groupid.foo > > as > > long as we are consistent and every one is fine with the convention > > chosen. > > > > Gruß > > Richard > > > > > > > > Am Mittwoch, dem 28.09.2022 um 12:50 -0500 schrieb David Blevins: > > > Thanks for the proposal and the email! > > > > > > I think it's fantastic to get the version strings normalized to > > > `version.foo`. We started with `foo.version` and gradually > > > changed to > > > `version.foo` as that kind of thing became more favored by Maven > > > in > > > general, but we never went back and fixed the old properties so > > > we > > > have a mix. Great to see that addressed. The big PR is fine for > > > me > > > -- let's get a CI build as Richard suggests. > > > > > > In terms of the format, are we open to keeping it a simple > > > `version.foo` versus adding various prefixes before the `foo` > > > part > > > such as `tomee`, `api` or the groupId? I'll never remember which > > > prefix rule goes where and when, so I'll constantly be looking it > > > up > > > and also further (unintentionally) adding to the inconsistency. > > > > > > Intellij does have completion for Maven properties. Being able to > > > type `version.` and then get a flat list of all the names would > > > be > > > fantastic. > > > > > > Thoughts? > > > > > > > > > -David > > > > > > > > > > On Sep 28, 2022, at 9:25 AM, Swell <[email protected]> > > > > wrote: > > > > > > > > Hi everyone, > > > > > > > > The pom.xml of the project uses several properties to configure > > > > dependencies. some of which not used anymore since switching > > > > from > > > > geronimo > > > > to smallrye. > > > > > > > > i've been working on removing orphan properties, renaming > > > > versions > > > > props on > > > > the same format whenever i was able. reorganizing a bit. > > > > > > > > the proposed PR became a little big bang with almost 100 poms > > > > impacted, and > > > > hard to review. > > > > > > > > the possible course of action would be collecting opinion here > > > > by > > > > mail > > > > before merging, see if it breaks and possibly fix afterward. > > > > > > > > Thanks for your time. > > > > -- > > > > Swell
smime.p7s
Description: S/MIME cryptographic signature
