about the prefixes, there could be ambiguities or collisions when using short names, * group: 'org.apache.tomee', name: 'jakartaee-api', version: '9.1-M2' * group: 'jakarta.platform', name: 'jakarta.jakartaee-api', version: '9.1.0' the <version.jakartaee-api> property would be ambiguous.
but i agree we should keep things simple, maybe one rule with some room if it stays unambiguous. groupid or equivalent seems a good compromise to me, listening to your suggestions On Wed, 28 Sept 2022 at 19:51, David Blevins <[email protected]> wrote: > Thanks for the proposal and the email! > > I think it's fantastic to get the version strings normalized to > `version.foo`. We started with `foo.version` and gradually changed to > `version.foo` as that kind of thing became more favored by Maven in > general, but we never went back and fixed the old properties so we have a > mix. Great to see that addressed. The big PR is fine for me -- let's get > a CI build as Richard suggests. > > In terms of the format, are we open to keeping it a simple `version.foo` > versus adding various prefixes before the `foo` part such as `tomee`, `api` > or the groupId? I'll never remember which prefix rule goes where and when, > so I'll constantly be looking it up and also further (unintentionally) > adding to the inconsistency. > > Intellij does have completion for Maven properties. Being able to type > `version.` and then get a flat list of all the names would be fantastic. > > Thoughts? > > > -David > > > > On Sep 28, 2022, at 9:25 AM, Swell <[email protected]> wrote: > > > > Hi everyone, > > > > The pom.xml of the project uses several properties to configure > > dependencies. some of which not used anymore since switching from > geronimo > > to smallrye. > > > > i've been working on removing orphan properties, renaming versions props > on > > the same format whenever i was able. reorganizing a bit. > > > > the proposed PR became a little big bang with almost 100 poms impacted, > and > > hard to review. > > > > the possible course of action would be collecting opinion here by mail > > before merging, see if it breaks and possibly fix afterward. > > > > Thanks for your time. > > -- > > Swell > >
