potiuk commented on issue #339: URL: https://github.com/apache/tooling-trusted-releases/issues/339#issuecomment-3566874150
> Using f-strings for logging calls means that the string will be evaluated even if it is not actually needed. This is counter-intuitive, so the reason for it should be documented. Quite agree here. This is a common pitfall to use f-strings for logging in Python. Instead of documenting it here i would rather recommend to the "usual" logging style (with args and kwargs) and enforcing it not (at least not only) by a rule but by ruff rule https://docs.astral.sh/ruff/rules/logging-string-format/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
