potiuk commented on issue #339: URL: https://github.com/apache/tooling-trusted-releases/issues/339#issuecomment-3566878841
BTW. Very good idea to document code conventions in general, and your convention here is excellent in general - it contains mostly things that are difficult to automatically check and enforce, and is rather short thanks to that. My rule of thumb when introducing conventions: * if enforcable by linting/ruff automation - do it this way (and in prek hook with that) - if someone violates them, ruff error usually explains reasoning, links you to examples and often discusses pros/cons in a concise way. This is a fantastic learning for new contributors they can learn by doing (mistakes) and being corrected (automatically) - usually without too much of oversight * document what can't be enforced only (so that in case of reviews you can point people to those) Very good job on those @sbp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
