gstein commented on issue #339: URL: https://github.com/apache/tooling-trusted-releases/issues/339#issuecomment-3567191191
f-string formatting is so little overhead that it just doesn't matter whether it will be used or not. They are clearer, and readability improves the maintainability of the code. Obfuscating code for 0.12ms gain is not worthwhile. Please demonstrate that computation of an f-string has an impact on performance. Also note that logging calls are relatively rare within the overall app performance. There are not 10,000 logs written per second. That would be unreasonable and useless. So you're getting what? Maybe 10 logs per second? Absolute maximum? And the f-string construction will take about 1 millisecond of that? This is a moot optimization, at the cost of clarity. IMO, of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
