Abhishekmishra2808 commented on code in PR #608: URL: https://github.com/apache/tooling-trusted-releases/pull/608#discussion_r2739787706
########## atr/mail.py: ########## @@ -15,22 +15,21 @@ # specific language governing permissions and limitations # under the License. +# Licensed to the Apache Software Foundation (ASF) under one... (License block) + import dataclasses import email.utils as utils import ssl import time import uuid +from email.headerregistry import Address +from email.message import EmailMessage from typing import Final import aiosmtplib -# import dkim import atr.log as log -# TODO: We should choose a pattern for globals -# We could e.g. use uppercase instead of global_ -# It's not always worth identifying globals as globals -# But in many cases we should do so Review Comment: You’re right - this comment was unrelated to the fix. I’ve restored it unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
