Abhishekmishra2808 commented on code in PR #608:
URL:
https://github.com/apache/tooling-trusted-releases/pull/608#discussion_r2739791054
##########
atr/mail.py:
##########
@@ -115,13 +116,6 @@ async def _send_via_relay(from_addr: str, to_addr: str,
msg_bytes: bytes) -> Non
"""Send an email to a single recipient via the ASF mail relay."""
_validate_recipient(to_addr)
- # Connect to the ASF mail relay
- # NOTE: Our code is very different from the asfpy code:
- # - Uses types
- # - Uses asyncio
- # Due to the divergence, we should probably not contribute upstream
- # In effect, these are two different "packages" of functionality
- # We can't even sign it first and pass it to asfpy, due to its different
design
Review Comment:
Thanks for pointing this out. I’ve restored the original comment, as it
provides useful context and isn’t related to the CRLF fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
