Abhishekmishra2808 commented on PR #608: URL: https://github.com/apache/tooling-trusted-releases/pull/608#issuecomment-3815382213
I’ve updated the PR following your review, and I apologize for the earlier noise in the diff. Thank you for your patience and for the detailed feedback. - **Surgical Refactor**: Restored all original comments, method order, and the UUID4 random-bits explanation in `mail.py` to keep the change set minimal and easy to review. - **Signature Consistency**: Reverted `_send_many` to accept `msg_text: str`, matching the original public signature, while preserving the security fix internally via `EmailMessage`. - **Style Alignment**: Removed unnecessary docstrings and restored simple `#` comments to align with the project’s existing style. - **Clean Submission**: Removed the accidentally added `package-lock.json` and reverted unintended changes to typestubs so the PR remains strictly focused on the CRLF fix. **Verification** - All 11 unit tests pass locally. - All `make check` hooks complete successfully. Thanks again for the thorough review and guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
