[ https://issues.apache.org/jira/browse/TOREE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048207#comment-16048207 ]
ASF GitHub Bot commented on TOREE-380: -------------------------------------- Github user chipsenkbeil commented on a diff in the pull request: https://github.com/apache/incubator-toree/pull/104#discussion_r121758304 --- Diff: scala-interpreter/src/main/scala/org/apache/toree/kernel/interpreter/scala/ScalaDisplayers.scala --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License + */ + +package org.apache.toree.kernel.interpreter.scala + +import java.util + +import scala.collection.JavaConverters._ +import scala.collection.mutable +import scala.util.Try +import org.apache.spark.SparkContext +import org.apache.spark.sql.Row +import org.apache.spark.sql.SparkSession +import jupyter.Displayer +import jupyter.Displayers +import jupyter.MIMETypes +import org.apache.toree.kernel.protocol.v5.MIMEType +import org.apache.toree.magic.MagicOutput + +object ScalaDisplayers { + + def ensureLoaded(): Unit = () --- End diff -- Can you add a doc to explain that reason? Otherwise, I might forget later and try to remove it. > Interpreters should be allowed to send results other than text/plain. > --------------------------------------------------------------------- > > Key: TOREE-380 > URL: https://issues.apache.org/jira/browse/TOREE-380 > Project: TOREE > Issue Type: Improvement > Reporter: Ryan Blue > Assignee: Ryan Blue > > Jupyter allows kernels to send results using different content types, but > this isn't allowed by Toree for its interpreters. This prevents custom > display logic. The basic problem is that {{ExecuteOutput}} is a {{String}} > and not a {{Map[String, String]}} like {{CellMagicOutput}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)