On Wed, Apr 29, 2009 at 5:31 PM, Luciano Resende <[email protected]> wrote:
> My take on this is that contribution module is about contribution > services, defining spis for these services, and extensions points, > where contribution-xml is about providing support for handling > sca-contribution.xml and sca-contribution-generated.xml files. Ok that helps a lot. So it sounds like these contribution modules have a different pattern to what we've had in the other modules which used a module for the scdl model and another module for the model XML processing. I wonder if there is still some refactoring that could be done here - it sounds like the "contribution" module includes the model code for the sca-contribution.xml and sca-contribution-generated.xml files as well as the code for the contribution service and its SPIs and extension points - perhaps the model code should be separated from the contribution service so there is module for the contribution service and another module for the sca-contribution model, and then the existing contribution-xml module gets merged into the new model module. (Which fits in nicely with a conversation from 2 years ago! http://apache.markmail.org/message/nncxz73tbozov44y) ...ant
