Luciano Resende wrote:
On Wed, Jun 24, 2009 at 9:07 AM, Raymond Feng<[email protected]> wrote:
Hi,
We have an agreed Eclipse template, why can't people have the code
formatting done using the code style in the 1st place?
+1, Although this is not mandatory, I'd really like to encourage the
Tuscany developers (at least the core ones) to be using the templates
as we describe in our developer guide. If there are issues with the
current template, let' s discuss it and fix it.
I prefer to use a plain text editor. I am careful to follow the
guidelines on tabs/spaces, long lines, and import ordering.
I don't mix reformatting with other changes. I don't think it
should be a requirement to use any particular editor.
Simon
I agree not to reformat the whole file at the same time when we fix the
code, but I don't think we go too far. I have a few things set up
automatically in Eclipse:
* Organize the imports
+1
* Convert the tab/space
+1
It helps me a lot to maintain the clean code with disturbing the diffs too
much.
+1
The other thing, can we reformat the whole code base before we cut a RC so
that we can have good style moving forward?
We could do this frequently, I tried the import/export in the whole
codebase and it seems to be very straightforward and I'll commit if I
don't see any build issues.
Thanks,
Raymond
--------------------------------------------------
From: "ant elder" <[email protected]>
Sent: Wednesday, June 24, 2009 7:02 AM
To: <[email protected]>
Subject: Re: Commit comment quality?
On Wed, Jun 24, 2009 at 2:27 PM, Luciano Resende<[email protected]>
wrote:
On Tue, Jun 23, 2009 at 11:36 PM, ant elder<[email protected]> wrote:
Does anyone disagree that commits should not mix formatting and code
changes?
There are some settings on the Eclipse templates we use that do some
conversion automatically (e.g tabs for spaces)... are those accepted
?
I'd don't think those should be done automatically and from other
projects its standard practice to to keep those separate in another
commit. We're all busy so reviewing changes should be able to be done
as quick and easily as possible, so ideally just read the comment and
a quick flick over the diff, if that diff includes many other lines of
change even just for tab/space changes it makes it harder than
necessary to see the actual code lines changed.
...ant
