On Wed, Jun 24, 2009 at 2:27 PM, Luciano Resende<[email protected]> wrote: > On Tue, Jun 23, 2009 at 11:36 PM, ant elder<[email protected]> wrote: >> >> Does anyone disagree that commits should not mix formatting and code >> changes? >> > > There are some settings on the Eclipse templates we use that do some > conversion automatically (e.g tabs for spaces)... are those accepted > ?
I'd don't think those should be done automatically and from other projects its standard practice to to keep those separate in another commit. We're all busy so reviewing changes should be able to be done as quick and easily as possible, so ideally just read the comment and a quick flick over the diff, if that diff includes many other lines of change even just for tab/space changes it makes it harder than necessary to see the actual code lines changed. ...ant
