On Wed, Jun 24, 2009 at 6:45 AM, Simon Laws<[email protected]> wrote: > On Wed, Jun 24, 2009 at 2:27 PM, Luciano Resende<[email protected]> wrote: >> On Tue, Jun 23, 2009 at 11:36 PM, ant elder<[email protected]> wrote: >>> >>> Does anyone disagree that commits should not mix formatting and code >>> changes? >>> >> >> There are some settings on the Eclipse templates we use that do some >> conversion automatically (e.g tabs for spaces)... are those accepted >> ? What makes things hard to see, is the CTRL+F to reformat or CTRL+I >> to reident the code when fixing a bug, and for that I'd prefer to use >> a separate commit. >> >> >> >> -- >> Luciano Resende >> Apache Tuscany, Apache PhotArk >> http://people.apache.org/~lresende >> http://lresende.blogspot.com/ >> > > Yeah, for me that's the issue. If we go in and fix a bug and > automatically reformat the whole source file at the same time and > commit then that makes it hard to spot the line that's actually > changed to fix a problem. Obviously if it's just reformatting around > the change to fit the change in that that's part of the change itself. > I'm talking about reformatting that is independent of the change. > > If large scale/automatic reformatting could be done separately from > changes to the logic then that would make life easier. > > Regards > > Simon >
Then, +1 -- Luciano Resende Apache Tuscany, Apache PhotArk http://people.apache.org/~lresende http://lresende.blogspot.com/
