On Sun, Mar 7, 2010 at 1:12 AM, Simon Laws <[email protected]> wrote: >> you've said the code isn't even working >> completely yet > > I said that there was still work to do on matching. This relates to > policy specific matching and not to unmatched intents checking. > >> so really it shouldn't be activated until it doesn't >> break other not directly related compliance tests. > > The unmatched intents code is not "breaking" compliance tests.
It may not be now but it was, and, as there were no Tuscany tests for the code commenting it out didn't break a single thing in Tuscany so commenting it out and raising a JIRA for it seems like a good thing to me. Anyway lets forget it for now as your suggestion below about excluding failing tests from surefire sounds good so lets do that. I've done this now in the trunk compliance-test modules, there are still some JIRAs that need raising so some of the comments are referencing JIRA TUSCANY-xxxx for those. > compliance tests are failing with this error because it's a valid > error in this case, i.e. the compliance tests have issues. It's in our > interests to have OASIS produce an accurate compliance suite. In > order to work through this with the OASIS guys I need the runtime to > exhibit this valid error. > > I understand your desire to have the otests run clean and be part of > the build. I would like that also. How about I disable the tests in > question in an Tuscany specific way. I can, for example, add the > following to our version of the assembly otest pom and check it in > under TUSCANY-3481 (I could do the same in CAA for TUSACNY-3482) > > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-surefire-plugin</artifactId> > <version>2.4.3</version> > <configuration> > <excludes> > <!-- see TUSCANY-3481 --> > <exclude>**/ASM_6015_TestCase.java</exclude> > </excludes> > </configuration> > </plugin> > > Simon > > -- > Apache Tuscany committer: tuscany.apache.org > Co-author of a book about Tuscany and SCA: tuscanyinaction.com >
