[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570004#comment-15570004
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83108861
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java
 ---
    @@ -55,9 +58,11 @@ public JsonElement serialize(TwillRunResources src, Type 
typeOfSrc, JsonSerializ
         if (src.getDebugPort() != null) {
           json.addProperty(DEBUG_PORT, src.getDebugPort());
         }
    -    if (src.getLogLevel() != null) {
    -      json.addProperty(LOG_LEVEL, src.getLogLevel().toString());
    +    if (src.getRootLogLevel() != null) {
    +      json.addProperty(LOG_LEVEL, src.getRootLogLevel().toString());
    --- End diff --
    
    for serializing enum, always use `.name()` instead of `.toString()`.


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to