[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570162#comment-15570162
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user yaojiefeng commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83117482
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java 
---
    @@ -149,6 +161,51 @@ public void setServices(List<String> services) {
         return services.get();
       }
     
    +  /**
    +   * Get the map of the log level arguments of the twill application.
    +   *
    +   * @return the map of the log level arguments of the twill application
    +   */
    +  @Override
    +  public Map<String, Map<String, LogEntry.Level>> getLogLevels() {
    +    return logLevels;
    +  }
    +
    +  /**
    +   * Save the log levels for the twill runnable.
    +   *
    +   * @param runnableName name of the runnable.
    +   * @param logLevels map of the log level arguments to be saved.
    +   */
    +  public void setLogLevels(String runnableName, Map<String, 
LogEntry.Level> logLevels) {
    +    Map<String, LogEntry.Level> newlogLevels = new 
ConcurrentHashMap<>(logLevels);
    --- End diff --
    
    Yes. There will be no concurrent calls since this method is called in the 
wrap of `ContainerLock`. But immutable map cannot be used since we need to put 
values to the map if there is update


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to