Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83109907
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/state/SystemMessages.java ---
    @@ -68,6 +73,31 @@ public static Message updateRunnablesInstances(Command 
updateCommand) {
         return new SimpleMessage(Message.Type.SYSTEM, Message.Scope.RUNNABLES, 
null, updateCommand);
       }
     
    +  /**
    +   * Helper method to get System {@link Message} for changing the log 
levels for all runnables.
    +   *
    +   * @param logLevels The log levels to be changed.
    +   * @return An instance of System {@link Message} to change the log 
levels.
    +   */
    +  public static Message setLogLevels(Map<String, LogEntry.Level> 
logLevels) {
    +    return setLogLevels(null, logLevels);
    +  }
    +
    +  /**
    +   * Helper method to get System {@link Message} for changing the log 
levels for one or all runnables.
    +   *
    +   * @param runnableName The name of the runnable to set the log level, 
ALL if apply to all runnables.
    +   * @param logLevels The log levels to be changed.
    +   * @return An instance of System {@link Message} to change the log 
levels.
    +   */
    +  public static Message setLogLevels(String runnableName, Map<String, 
LogEntry.Level> logLevels) {
    --- End diff --
    
    Seems like `runnableName` is nullable. Please add the `@Nullable` 
annotation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to