Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83116780
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
 ---
    @@ -200,7 +201,9 @@ private RunningContainers 
initRunningContainers(ContainerId appMasterContainerId
           Integer.parseInt(System.getenv(EnvKeys.YARN_CONTAINER_MEMORY_MB)),
           appMasterHost, null, null);
         String appId = 
appMasterContainerId.getApplicationAttemptId().getApplicationId().toString();
    -    return new RunningContainers(appId, appMasterResources, zkClient);
    +    return new RunningContainers(appId, appMasterResources, zkClient,
    +                                 twillRuntimeSpec.getLogLevels(), 
applicationLocation,
    +                                 new 
ArrayList<>(twillSpec.getRunnables().keySet()));
    --- End diff --
    
    No need to copy since twill spec is immutable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to