Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r130407739
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -205,8 +208,9 @@ private RunningContainers
createRunningContainers(ContainerId appMasterContainer
Integer.parseInt(System.getenv(EnvKeys.YARN_CONTAINER_MEMORY_MB)),
appMasterHost, null);
String appId =
appMasterContainerId.getApplicationAttemptId().getApplicationId().toString();
- return new RunningContainers(appId, appMasterResources, zkClient,
applicationLocation,
- twillSpec.getRunnables(), twillRuntimeSpec.getMaxRetries());
+ return new RunningContainers(twillRuntimeSpec.getTwillAppName(),
twillRuntimeSpec.getTwillAppRunId(),
--- End diff --
Better just pass the `twillRuntimeSpec` to the `RunningContainers` instead
of getting individual entries one by one. It can replace the
`twillRuntimeSpec.getXXX` and `twillSpec.getRunnables`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
