Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r130407371 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -135,6 +135,9 @@ private final Map<String, Map<String, String>> environments; private final TwillRuntimeSpecification twillRuntimeSpec; + private volatile boolean completed; --- End diff -- Instead of having three variables for `completed`, `aborted`, `stopped`, it's better to have one Enum to represent them.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---