Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131209163
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -135,6 +135,15 @@
private final Map<String, Map<String, String>> environments;
private final TwillRuntimeSpecification twillRuntimeSpec;
+ /**
+ * Final status of this service when it stops.
+ */
+ public enum FinalStatus {
--- End diff --
Sounds more like `StopStatus` or `CompletionStatus`. Also it should be
`private` since it is only used in this class.
Also, please move it before all fields declaration instead of having it in
between fields.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
