[
https://issues.apache.org/jira/browse/UIMA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130534#comment-13130534
]
Joern Kottmann commented on UIMA-2266:
--------------------------------------
Feedback to your commit. The Cas Editor Ide Plugin is the one which integrates
the Cas Editor into the eclipse workspace, that means, opening a CAS from a
workspace file, loading the type system from a workspace file.
A file based search strategy should be part of the Ide Plugin and not of the
Cas Editor (core). The Cas Editor core part has an extension point for a Cas
Document Provider, and this document provider is responsible to find the type
system, depending on the integration that can come from many non-IFile sources.
Therefore we should move the strategy code over to the Ide Plugin.
In the DefaulCasDocumentProvider you removed white spaces and did formatting,
that makes it difficult to read the diff. Please don't do that in the
combination with code changes.
Does the current implementation work for you?
> Enable multiple strategies for finding a suitable type system
> -------------------------------------------------------------
>
> Key: UIMA-2266
> URL: https://issues.apache.org/jira/browse/UIMA-2266
> Project: UIMA
> Issue Type: New Feature
> Components: CasEditor
> Affects Versions: 2.4.0SDK
> Reporter: Peter Klügl
> Assignee: Peter Klügl
> Priority: Minor
>
> Add an extension point for type system search strategies (maybe with
> priorities). The different strategies need then to be applied in
> DefaultCasDocumentProvider.createDocument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
