Thanks James! it may take a while until we get to review it. (It even took a while to reply to this mail ;))
Cheers, -- Richard On 22.11.2013, at 22:35, James Jichun Zhu <[email protected]> wrote: > Richard and Marshall: > > I've completed the necessary code changes to implement the new feature I > proposed for issue UIMA-3374. I've attached the two java files I had to > change and a few screenshot to show the new feature. > > I am looking forward to someone reviewing it and providing feedbacks. > > Thank you. > > -- > James > > On Wed, Nov 6, 2013 at 11:32 AM, Richard Eckart de Castilho > <[email protected]>wrote: > >> James, >> >> to contribute your changes back, you open a JIRA issue and attach your >> changes as a patch. The patch needs to be reviewed by a project member >> which interacts with you in case the patch requires additional changes, or >> applies the change. Before a patch can be accepted, you need to file an >> individual contributor license agreement (ICLA) with the Apache Foundation >> (unless the patch is insignificant, which doesn't appear to be the case >> here). You need to decide if you also should file a Corpora CLA (CCLA), by >> which your employer gives consent to your contribution. The latter is >> basically to protect yourself. >> >> The issue you already have. When you have a patch, add it there. >> >> If you are not subscribed to the dev@uima list, you should probably >> subscribe. >> >> Cheers, >> >> -- Richard >> >> On 06.11.2013, at 20:22, James Jichun Zhu <[email protected]> wrote: >> >>> Marshall and Richard: >>> >>> From the source code I could see that there were two view modes, >> "annotation" mode and "entity" mode. The "annotation" mode is the default >> view mode that we commonly see. I've never realized there was an "entity" >> view mode until I saw it in the source code. >>> >>> The choice of view mode is controlled by two radio buttons. However, >> those radio buttons are rendered invisible. So the annotation viewer always >> renders the "annotation" view by default. It can be seen from the source >> code that the "entity" view mode was probably added at a later time and it >> appeared to be implemented with minimum code changes to follow the existing >> code for the "annotation" view mode and appeared to be missing code in a >> few places. >>> >>> Now, when I introduce a view mode, which I call "feature" mode, I need >> to add one more radio button so I can switch between the different view >> modes. The radio button has to be visible. When it is visible, it also >> makes the other two radio buttons visible, which essentially exposes the >> "entity" view mode that we don't normally see. >>> >>> Since I have not heard from you for the first few days, I decided to >> give it a try to re-implement all three view modes by taking them into >> consideration at the same time, instead of doing the new view mode as an >> after-thought. I am on my way to code complete and testing. >>> >>> Once I feel confident about the new code, I wonder what the process is >> to contribute it back to the UIMA. >>> >>> Thanks. >>> >>> James >>> >>> On 11/5/2013 11:34 AM, Richard Eckart de Castilho wrote: >>> >>>> That code has probably been sitting around for the last couple of >>>> releases, so we have it in various tags. Why not purge it from >>>> trunk? If the code around it changes, it soon becomes meaningless >>>> anyway. >>>> >>>> -- Richard >>>> >>>> On 05.11.2013, at 20:32, Marshall Schor <[email protected]> wrote: >>>> >>>>> Hi James, >>>>> >>>>> I suggest commenting out the unused code - would that work? >>>>> >>>>> -Marshall (feeling conservative ...) >>>>> >>>>> On 10/30/2013 7:04 PM, James Jichun Zhu wrote: >>>>>> Hi, Marshall Schor: >>>>>> >>>>>> I am looking into implementing a new mode for the annotation viewer >> (for >>>>>> details please see the UIMA issue #3374). I do feel the new feature I >> am >>>>>> about to implement will be of great value and intend to contribute it >> back >>>>>> to the UIMA code base once I have successfully implemented it. >>>>>> >>>>>> While going through the source code, I noticed that the code (more >>>>>> specifically, a class >> org.apache.uima.tools.viewer.CasAnnotationViewer in >>>>>> the SVN trunk) has not been significantly updated ever since its >> initial >>>>>> import on 11/02/2006. There is a feature called "entity mode" that is >>>>>> half-baked and disabled since it was not quite completed. It >> significantly >>>>>> complicated the code structure and made my implementation of the new >> view >>>>>> mode unnecessarily complicated as well. >>>>>> >>>>>> So, I am wondering if we should clean out the unused code so I can >>>>>> implement the new feature on a cleaner code base. If you can get hold >> of >>>>>> whoever that used to own this piece of code and get some of his/her >> opinion >>>>>> of it that would be great too. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> James >>>>>> >>>>>> >>>>>> On Fri, Oct 25, 2013 at 1:31 AM, Peter Klügl (JIRA) < >> [email protected]>wrote: >>>>>> >>>>>>> [ >>>>>>> >> https://issues.apache.org/jira/browse/UIMA-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805161#comment-13805161 >> ] >>>>>>> >>>>>>> Peter Klügl commented on UIMA-3374: >>>>>>> ----------------------------------- >>>>>>> >>>>>>> I had lately a discussion about different highlighting in the CAS >> Editor >>>>>>> dependent on the feature values (as the CAS Editor assigns one color >> to one >>>>>>> type, impractical if the semantic is defined by a feature). I will >> probably >>>>>>> open the same feature request for the CAS Editor sometime. >>>>>>> >>>>>>> As a side note: >>>>>>> The UIMA Ruta Workbench provides a view for querying collections of >> xmi >>>>>>> files with rules. You could use that view for getting a list of all >>>>>>> annotations with a certain feature value. >>>>>>> >>>>>>>> A new mode for annotation viewer based on feature values >>>>>>>> -------------------------------------------------------- >>>>>>>> >>>>>>>> Key: UIMA-3374 >>>>>>>> URL: https://issues.apache.org/jira/browse/UIMA-3374 >>>>>>>> Project: UIMA >>>>>>>> Issue Type: Improvement >>>>>>>> Components: InternalTools >>>>>>>> Affects Versions: 2.5.0SDK >>>>>>>> Reporter: James Zhu >>>>>>>> Priority: Minor >>>>>>>> Labels: newbie >>>>>>>> Original Estimate: 504h >>>>>>>> Remaining Estimate: 504h >>>>>>>> >>>>>>>> I'd like to propose adding a new "view mode" in the UIMA Annotation >>>>>>> Viewer so that user can pick a specific type of annotations, and >> then pick >>>>>>> a specific feature, and pick specific feature values available so >> user can >>>>>>> see a subset of those annotation objects that have the specific >> feature >>>>>>> values.
