Hi, Marshall: Thanks for spending the time going through the code and providing feedback.
I understand it is going to be very difficult to review the code if you compare mine with the old version line by line. The work you are seeing is the accumulative result after a few weeks of hard work. When I started out, I actually followed a patch-by-patch approach in order to gain an in-depth understanding of the original code so I don't miss any minute details, and try to inject the new code for my new functionality. I had to do a lot of refactoring of the old code to untangle the logic so that I can add the new functionality without making it even more tangled. I'd say the cleaning up is more than half of the work I did. Once it was done, adding the new feature was much simpler. If I had to deliver a patch with the first 3 changes, we are actually very close to delivering the whole pack of changes including the new feature. But I will be more than happy to work through the process to demonstrate how I went through the first 3 types of changes to clean up the code and then add my new functionality, if anyone is interested. Just let me know how we should proceed from here. Thanks! -- James On Mon, Dec 2, 2013 at 1:38 PM, Marshall Schor (JIRA) <[email protected]>wrote: > > [ > https://issues.apache.org/jira/browse/UIMA-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836947#comment-13836947] > > Marshall Schor commented on UIMA-3374: > -------------------------------------- > > I'm having a very hard time absorbing this change; it would help me (and > perhaps others) if it was delivered in several "doses" which could be > individually reviewed. > > Part of the review process is comparing the new with the old to see > exactly what the differences are. > > There are multiple kinds of differences: 1) renaming of fields and > methods. 2) moving fields / methods, reformatting with different # of > chars per line, changing/removing comments, 3) adding new widgets, > methods, etc. for new functionality. > > There is a lot of (1) and (2). I'm wondering if these could be delivered > as separately reviewable patches. That is, first do a patch which only > does renaming; then do a patch which only does "moving" things around, then > do a patch (if needed) which does reformatting (I recommend, though, > instead, you set your Eclipse (if you're using that) to a line-length and > comment-line length of 100 to match the existing file), and finally, do a > patch which does the new function(s). > > Of course, if you could dispense with any of the first 3 changes > (renaming, moving, reformatting), that would be OK as well :-). > > Others may be able to do the review without all this :-) ... > > > A new mode for annotation viewer based on feature values > > -------------------------------------------------------- > > > > Key: UIMA-3374 > > URL: https://issues.apache.org/jira/browse/UIMA-3374 > > Project: UIMA > > Issue Type: Improvement > > Components: InternalTools > > Affects Versions: 2.5.0SDK > > Reporter: James Zhu > > Priority: Minor > > Labels: annotation, feature, filter, type, value, viewer > > Attachments: CasAnnotationViewer.java, EntityResolver.java, > screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, screenshot-4.jpg > > > > Original Estimate: 504h > > Remaining Estimate: 504h > > > > I'd like to propose adding a new "view mode" in the UIMA Annotation > Viewer so that user can pick a specific type of annotations, and then pick > a specific feature, and pick specific feature values available so user can > see a subset of those annotation objects that have the specific feature > values. > > > > -- > This message was sent by Atlassian JIRA > (v6.1#6144) >
