I'd agree with Marshall that it would be nice to have "generalization" for a feature like this. More specifically, what I've implemented only allows user to filter annotation objects by a single feature and its values. It would be nicer if we could allow users to filter by multiple features and their values simultaneously. Of course it would require more work in order to have that capability.
I feel what I have is a good intermediate solution for now. It maintains 100% of all the existing functionality of the annotation viewer, and it has 0 impact to the users if they choose to not to use the new feature I added. My selfish motivation for contributing it back to the Apache UIMA project is that I don't need to carry the code myself and I don't need to recompile my annotation viewer with every new release of UIMA. I understand that you are concerned with too many changes to the one Java class. We talked about delivering a patch that contains only the cosmetic changes, and then a final patch with my new feature code changes. Would you still be interested in seeing that? I will need to spend some time in retracing the code changes I made but it is doable. Thanks. James On Wed, Mar 26, 2014 at 6:39 AM, Marshall Schor (JIRA) <[email protected]>wrote: > > [ > https://issues.apache.org/jira/browse/UIMA-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947910#comment-13947910] > > Marshall Schor commented on UIMA-3374: > -------------------------------------- > > I think this needs more careful investigation, and some thinking about the > generalizations. I would not apply the patch as it is now. This is lower > priority for me at this moment. > > > A new mode for annotation viewer based on feature values > > -------------------------------------------------------- > > > > Key: UIMA-3374 > > URL: https://issues.apache.org/jira/browse/UIMA-3374 > > Project: UIMA > > Issue Type: Improvement > > Components: InternalTools > > Affects Versions: 2.5.0SDK > > Reporter: James Zhu > > Assignee: Marshall Schor > > Priority: Minor > > Labels: annotation, feature, filter, type, value, viewer > > Attachments: CasAnnotationViewer.java, EntityResolver.java, > screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, screenshot-4.jpg > > > > Original Estimate: 504h > > Remaining Estimate: 504h > > > > I'd like to propose adding a new "view mode" in the UIMA Annotation > Viewer so that user can pick a specific type of annotations, and then pick > a specific feature, and pick specific feature values available so user can > see a subset of those annotation objects that have the specific feature > values. > > > > -- > This message was sent by Atlassian JIRA > (v6.2#6252) >
