Checked release notes - ok
Checked changes to source - ok
- The only real changes is the performance improvement, the rest is just 
boilerplate.

Checked issues list - ok
- I wonder why one cannot view the issues list on Jira when not logged in to 
Jira... 

Checked signatures on release artifacts - ok

Checking git history, it seems the "uimaj-3.1.1" tag is misplaced:
- it should be at 35ae2c876783d4a94b0e059300dc4a47af334b71 (04.11.2019)
- but it is at    61e547c5975f64895d5f9f71e6405b2589e39fe0 (28.10.2019)
  the "jira.version" property in 61e547c5975f64895d5f9f71e6405b2589e39fe0 still 
points to 3.1.0SDK
  which is not on the rc/uimaj-3.1.1 branch
  Well, this is easy to fix.
- Why do we have two releases, i.e. one for UIMAJ and one for the update site?

Considering that the Jira version in the release artifacts points to 
"3.1.1SDK", I guess that
the artifacts were built from 35ae2c876783d4a94b0e059300dc4a47af334b71 and not 
from 61e547c5975f64895d5f9f71e6405b2589e39fe0 (where the tag is)?

We might care considering enhancing the build process such that is stores the 
commit ID from which the release is carved into some file.

Do you agree that the "uimaj-3.1.1" tag is on the wrong commit? 
Before continuing the review, would you move it to 
35ae2c876783d4a94b0e059300dc4a47af334b71?

Best,

-- Richard

Reply via email to