hmmm, I'm not sure how to reproduce that funny tag. On my git local dir, where I did the work, I did a git fetch, and then did a git status - which said: --------------- git status On branch rc/uimaj-3.1.1 Your branch is up to date with 'origin/rc/uimaj-3.1.1'.
Untracked files: (use "git add <file>..." to include in what will be committed) issuesFixed/ uimaj-eclipse-update-site/category.xml uimaj-eclipse-update-site/pom.xml.releaseBackup uimaj-eclipse-update-site/release.properties nothing added to commit but untracked files present (use "git add" to track) --------------------- Then I did a "git log" and looked for the commit which was labeled tag: uimaj-3.1.1, and it was this line: -------------------- commit 35ae2c876783d4a94b0e059300dc4a47af334b71 (tag: uimaj-3.1.1) Author: Marshall Schor <[email protected]> Date: Mon Nov 4 10:04:20 2019 -0500 Where are you seeing it point to that other value? -Marshall On 11/4/2019 5:11 PM, Richard Eckart de Castilho wrote: > Checked release notes - ok > Checked changes to source - ok > - The only real changes is the performance improvement, the rest is just > boilerplate. > > Checked issues list - ok > - I wonder why one cannot view the issues list on Jira when not logged in to > Jira... > > Checked signatures on release artifacts - ok > > Checking git history, it seems the "uimaj-3.1.1" tag is misplaced: > - it should be at 35ae2c876783d4a94b0e059300dc4a47af334b71 (04.11.2019) > - but it is at 61e547c5975f64895d5f9f71e6405b2589e39fe0 (28.10.2019) > the "jira.version" property in 61e547c5975f64895d5f9f71e6405b2589e39fe0 > still points to 3.1.0SDK > which is not on the rc/uimaj-3.1.1 branch > Well, this is easy to fix. > - Why do we have two releases, i.e. one for UIMAJ and one for the update site? > > Considering that the Jira version in the release artifacts points to > "3.1.1SDK", I guess that > the artifacts were built from 35ae2c876783d4a94b0e059300dc4a47af334b71 and > not from 61e547c5975f64895d5f9f71e6405b2589e39fe0 (where the tag is)? > > We might care considering enhancing the build process such that is stores the > commit ID from which the release is carved into some file. > > Do you agree that the "uimaj-3.1.1" tag is on the wrong commit? > Before continuing the review, would you move it to > 35ae2c876783d4a94b0e059300dc4a47af334b71? > > Best, > > -- Richard >
