sergehuber commented on code in PR #715:
URL: https://github.com/apache/unomi/pull/715#discussion_r2428599056
##########
graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/condition/parsers/SegmentProfileEventsConditionParser.java:
##########
@@ -185,9 +185,16 @@ private Map<String, Object>
createProfileEventPropertyField(final Condition cond
tuple.put("fieldName", "cdp_timestamp_gte");
}
- final OffsetDateTime fieldValue =
DateUtils.offsetDateTimeFromMap((Map<String, Object>)
condition.getParameter("propertyValueDate"));
-
- tuple.put("fieldValue", fieldValue != null ? fieldValue.toString()
: null);
+ Object propertyValueDate =
condition.getParameter("propertyValueDate");
+ if (propertyValueDate == null) {
+ tuple.put("fieldValue", null);
+ } else if (propertyValueDate instanceof Map){
+ // This shouldn't be needed since Jackson was upgraded to >
2.13, but we keep it for backwards compatibility with older data sets
+ final OffsetDateTime fieldValue =
DateUtils.offsetDateTimeFromMap((Map<String, Object>) propertyValueDate);
+ tuple.put("fieldValue", fieldValue != null ?
fieldValue.toString() : null);
+ } else {
+ tuple.put("fieldValue", propertyValueDate.toString());
+ }
Review Comment:
I've removed this fix. It was identified during manual testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
