sergehuber commented on PR #715: URL: https://github.com/apache/unomi/pull/715#issuecomment-3407820589
**Changes since February on OpenSearch contribution** After a LOT of work, I have updated this PR. Hopefully, it will address all the feedback from the reviews and can be merged soon to avoid having to track changes on the master branch again. Here is a summary of the changes: - Merged with the latest changes from the master branch, including ES 9 support and Karaf 4.4.8 (tricky merge!) - Upgraded OpenSearch support to version 3 (was on 2.18 previously) - Removed all the non-OpenSearch related changes - Added missing Javadocs - Addressed all the points raised by the reviewers that were relevant - Renamed all the _queryBuilderIds_ and removed the *ESQueryBuilder postfix in the queryBuilderIds, replacing them with *QueryBuilder. For example, we had queryBuilderId=booleanConditionESQueryBuilder for both OpenSearch and ElasticSearch, so I simply renamed this to booleanConditionQueryBuilder. In order to avoid introducing a breaking change, I added a system to map old queryBuilderIds to new ones that issues a warning if a legacy ID is being used but still allows the old IDs to work transparently. Also documented the system in the migration guide. - Developed integration tests for the queryBuilderId mapping system - Updated the Healthcheck provider to now only report the persistence implementation that is being used - Documented the new start configuration system and explained how it can be used for custom deployments or distributions - Removed the Hover event query builder implementation and simply replaced it with a condition type with a parent condition. This way it can work on both ElasticSearch and OpenSearch. Also added a hover event JSON schema built into the plugin. All the tests are green on GitHub, and the code is ready for review (again)! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
