sergehuber commented on code in PR #715:
URL: https://github.com/apache/unomi/pull/715#discussion_r2426648162


##########
docker/README.md:
##########
@@ -48,21 +48,66 @@ For ElasticSearch:
     docker pull docker.elastic.co/elasticsearch/elasticsearch:7.4.2
     docker network create unomi
     docker run --name elasticsearch --net unomi -p 9200:9200 -p 9300:9300 -e 
"discovery.type=single-node" -e cluster.name=contextElasticSearch 
docker.elastic.co/elasticsearch/elasticsearch:7.4.2
+
+For OpenSearch:
+
+    docker pull opensearchproject/opensearch:2.18.0
+    docker network create unomi
+    export OPENSEARCH_ADMIN_PASSWORD=enter_your_custom_admin_password_here
+    docker run --name opensearch --net unomi -p 9200:9200 -p 9300:9300 -e 
"discovery.type=single-node" -e 
OPENSEARCH_INITIAL_ADMIN_PASSWORD=${OPENSEARCH_ADMIN_PASSWORD} 
opensearchproject/opensearch:2.18.0
     
-For Unomi:
+For Unomi (with ElasticSearch):
+
+    docker pull apache/unomi:2.7.0-SNAPSHOT
+    docker run --name unomi --net unomi -p 8181:8181 -p 9443:9443 -p 8102:8102 
\
+        -e UNOMI_ELASTICSEARCH_ADDRESSES=elasticsearch:9200 \
+        apache/unomi:2.7.0-SNAPSHOT
 
-    docker pull apache/unomi:2.0.0-SNAPSHOT
-    docker run --name unomi --net unomi -p 8181:8181 -p 9443:9443 -p 8102:8102 
-e UNOMI_ELASTICSEARCH_ADDRESSES=elasticsearch:9200 apache/unomi:2.0.0-SNAPSHOT
+For Unomi (with OpenSearch):
 
-## Using a host OS ElasticSearch installation (only supported on macOS & 
Windows)
+    docker pull apache/unomi:2.7.0-SNAPSHOT
+    docker run --name unomi --net unomi -p 8181:8181 -p 9443:9443 -p 8102:8102 
\
+        -e UNOMI_AUTO_START=opensearch \
+        -e UNOMI_OPENSEARCH_ADDRESSES=opensearch:9200 \
+        -e UNOMI_OPENSEARCH_PASSWORD=${OPENSEARCH_ADMIN_PASSWORD} \
+        apache/unomi:2.7.0-SNAPSHOT
+
+## Using a host OS Search Engine installation (only supported on macOS & 
Windows)
+
+For ElasticSearch:
 
-    docker run --name unomi -p 8181:8181 -p 9443:9443 -p 8102:8102 -e 
UNOMI_ELASTICSEARCH_ADDRESSES=host.docker.internal:9200 
apache/unomi:2.0.0-SNAPSHOT
+    docker run --name unomi -p 8181:8181 -p 9443:9443 -p 8102:8102 \
+        -e UNOMI_ELASTICSEARCH_ADDRESSES=host.docker.internal:9200 \
+        apache/unomi:2.7.0-SNAPSHOT
+
+For OpenSearch:
+
+    docker run --name unomi -p 8181:8181 -p 9443:9443 -p 8102:8102 \
+        -e UNOMI_AUTO_START=opensearch \
+        -e UNOMI_OPENSEARCH_ADDRESSES=host.docker.internal:9200 \
+        -e UNOMI_OPENSEARCH_PASSWORD=${OPENSEARCH_ADMIN_PASSWORD} \
+        apache/unomi:2.7.0-SNAPSHOT
 
 Note: Linux doesn't support the host.docker.internal DNS lookup method yet, it 
should be available in an upcoming version of Docker. See 
https://github.com/docker/for-linux/issues/264
 
+## Environment Variables
+
+### Common Variables
+- `UNOMI_AUTO_START`: Specifies the search engine type (`elasticsearch` or 
`opensearch`, defaults to `elasticsearch`)

Review Comment:
   This was replaced because it is now named a startConfiguration. So basically 
we can select start configurations in autostart or start command. Start 
configurations are designed to be extendable and customizable in the 
org.apache.unomi.start.cfg so that people may for example add their own 
features to be started or build additional customizations. For the moment this 
is only used for opensearch and elasticsearch but could be useful in the future 
for other Unomi extensions or repackagings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to