Gwyn Evans wrote:
On Wednesday, September 19, 2007, 12:12:16 AM, Ate <[EMAIL PROTECTED]> wrote:
Since -beta3, there have been several other commits to the trunk
which also affect critical areas like url handling: should those not have been
applied either?
Probably not! :-)
The amount of changes to the existing code isn't very big and won't cost you
much time to review.
If you're willing to do so, I'd suggest checking out the -beta3
release and apply the patch file I attached to WICKET-983. Then, using the
Eclipse Team
Synchronization Perspective, you can get a quick view on all the changes,
within context.
I used IDEA, but yes - the only issues I had were the changed test
expectations in jdk-1.4\wicket\src\test\java\org\apache\wicket\ajax\
markup\html\componentMap\SimpleTestPageExpectedResult.html &
SimpleTestPageExpectedResult-1.html, where the change in
AbstractAjaxBehaviour.java results in the test page having a
IActivePageBehaviorListener rather than a IBehaviorListener.
Ouch, I missed that one.
Strangely enough though this test doesn't fail when run during the build of
wicket, but when invoked directly it does.
Weird.
It can easily be fixed of course which I'll do in a minute.
I also provided a build wicket-examples.war based on the
portlet-support branch for testing purposes which you can deploy in any servlet
container:
http://people.apache.org/~ate/wicket/wicket-examples.war
I used the one I built, but no problems found.
Cool, good to hear.
At the moment I'd have a "-0.2" position on things, i.e. slightly
negative, as I want to get a 1.3 release out and have concerns that
this might delay things, but open to persuasion & would welcome some
input from someone more familiar with the core than I am who might be
able to comment as to if my concerns are likely to be unfounded.
Well, I can't see any problems, no one else has raised anything &
we're still getting a reasonable rate of issues being raised/fixed on
trunk, so I'm happy for you to apply the changes now... it's cost you
though! :-)
LOL, I knew this was coming ;)
How about, once this is all in & working OK, about doing a couple of
wiki articles - One "Hello Portal" for users, describing how to get
started with Wicket and an example portal server, and a second for the
developers, flagging things to watch out for when coding the core?
Yes, I will. I already had that on my todo list.
Thanks for the support,
Ate
/Gwyn
