I have submitted the javadoc here: https://issues.apache.org/jira/browse/PB-87
Should methods that are simple implementations of interfaces, where existing javadoc *only* contains the "see implemented interface method" note, shouldn't that method have no javadoc, so that the javadoc gets properly inherited from the implemented interface? In the patch I have removed some 'empty' java doc of this fashion, unless I've been able to add something to it. "pathInfo" seems to be commonly used to refer to the request url minus the context and filter path. why is it called path 'info'? cant think of a better name myself atm though... I have also added a javadoc patch for the Apache Bridges parts that are used in the implementation here: https://issues.apache.org/jira/browse/PB-87 I have left the FIXME javadoc markers in where I am either not happy with what I've/is written, or if I explicitly need someone to check what I wrote. Have a look at let me know what you think... Now that I'm all environment-ed up and familiar with the code, time to get cracking on events! For anyone trying to get all this going on pluto, you should be aware of: https://issues.apache.org/jira/browse/PLUTO-517 https://issues.apache.org/jira/browse/PLUTO-516 https://issues.apache.org/jira/browse/PLUTO-508 Cheers. I will be addressing the other replies tomorrow. P.s. - I'm looking forward to working the rest of the portal implementation _with_ this javadoc in the code base ;) Antony Stubbs wrote: > > Morning guys, > > This is msg is of course regarding the continuation and the finishing of > the > Portal 2.0 wicket support. I plan on continuing from Thijs' work done on > WICKET-1620 here: > > Here are the two historical conversations regarding the topic > -Portal 2 implementation: > http://www.nabble.com/Portlet-2.0-implementation-in-Wicket-td17187909.html > -original portal 1 implementation: > http://www.nabble.com/A-new-proposal-for-Wicket-Portlet-support-td10863022.html > > I met with Ate the other day in Utrecht, Netherlands and we discused > various > things, some of which was the strategy we would adopt going forward with > the > P2 development. > > ------snip-------- > > ----- ___________________________ http://stubbisms.wordpress.com http://stubbisms.wordpress.com -- View this message in context: http://www.nabble.com/Finishing-Portal-2.0-development-tp19909563p20097140.html Sent from the Wicket - Dev mailing list archive at Nabble.com.
