ok. lets consider this vote closed. there doesnt seem to be a good way to fix utf8 thing, i am going to roll it back and recreate 1.4.2 sans that.
i will start a new vote thread when that is done. -igor On Tue, Sep 29, 2009 at 2:07 AM, Robin Sander <[email protected]> wrote: > > I doubt that this is possible, iso-8859-1 is not a subset of UTF-8 and > though it may be possible > to guess the encoding of a byte array it will always be just a guess. That's > one main > advantage of XML over plain text format, the encoding is stated upfront > (itself in a fixed > encoding btw.) > So with plain text you have to simply know the encoding before parsing it, > that's why Sun > had to define one for property (plain text) files. > > Robin. > > On Sep 28, 2009, at 18:36, Igor Vaynberg wrote: > >> Hrm. I thought the code was supposed to convert 8859 to utf8 on the >> fly. Can you please open a jira issue and attach a test case. >> >> -Igor >> >> On Mon, Sep 28, 2009 at 2:02 AM, Ernesto Reinaldo Barreiro >> <[email protected]> wrote: >>>> >>>> [ X] No, don't release it and here is why... >>>> >>> >>> After upgrading to 1.4.2 all my ISO-8859-1 encoded property files fail to >>> work. I haven't look into it in detail but I guess this is related to >>> * [WICKET-2451] - Add ability to load UTF-8 encoded properties not >>> in XML format. >>> >>> >>> I know I shouldn't be using ISO-8859-1... but right now I have a bunch of >>> those properties files. Is there an easy way to get around this?.... >>> After >>> looking into changes I see the line (379).... >>> >>> Reader reader = new InputStreamReader(is, "UTF-8"); >>> >>> Shouldn't this be cofingurable somehow? >>> >>> Best, >>> >>> Ernesto >>> >>> >>> On Mon, Sep 28, 2009 at 2:33 AM, Igor Vaynberg >>> <[email protected]>wrote: >>> >>>> all votes are more then welcome. >>>> >>>> -igor >>>> >>>> On Sun, Sep 27, 2009 at 5:20 PM, Sam Stainsby >>>> <[email protected]> wrote: >>>>> >>>>> Are non-binding votes preferred or discouraged here? If the former, >>>>> then >>>>> after some testing with my projects: >>>>> >>>>> (nonbinding) >>>>> [X] Yes release >>>>> [ ] No, don't release it and here is why... >>>>> >>>>> >>>> >>> > >
