Igor, can I ask you to work a bit on my patch for wicket-2491 in order to add
it to 1.4.2? I find the problem important because any mounted page
containing ajax multipart form submit does not work.
The fix can be wrong but it shows the key points where multipart form
submitting is inconsistent with the regular ajax submit.
I'm concerned about how MultipartServletWebRequest is created. It contains
its own copy of RequestParameters. I just propagated URL depth property that
is used when prepending the resource URL and I consider it inconsistent.
Pprobably propagation of RequestParameters instance would be more
consistent.
There is another problem. Multipart form ajax submit might result in
invocation of setResponsePage(). In fact in produces the response that
contains just "-" sign ("<ajax-response />" is expected afaik). Could you
have a look at that as well?
Robin Sander wrote:
>
>
> I doubt that this is possible, iso-8859-1 is not a subset of UTF-8 and
> though it may be possible
> to guess the encoding of a byte array it will always be just a guess.
> That's one main
> advantage of XML over plain text format, the encoding is stated
> upfront (itself in a fixed
> encoding btw.)
> So with plain text you have to simply know the encoding before parsing
> it, that's why Sun
> had to define one for property (plain text) files.
>
> Robin.
>
> On Sep 28, 2009, at 18:36, Igor Vaynberg wrote:
>
>> Hrm. I thought the code was supposed to convert 8859 to utf8 on the
>> fly. Can you please open a jira issue and attach a test case.
>>
>> -Igor
>>
>> On Mon, Sep 28, 2009 at 2:02 AM, Ernesto Reinaldo Barreiro
>> <[email protected]> wrote:
>>>> [ X] No, don't release it and here is why...
>>>>
>>>
>>> After upgrading to 1.4.2 all my ISO-8859-1 encoded property files
>>> fail to
>>> work. I haven't look into it in detail but I guess this is related to
>>> * [WICKET-2451] - Add ability to load UTF-8 encoded properties not
>>> in XML format.
>>>
>>>
>>> I know I shouldn't be using ISO-8859-1... but right now I have a
>>> bunch of
>>> those properties files. Is there an easy way to get around
>>> this?.... After
>>> looking into changes I see the line (379)....
>>>
>>> Reader reader = new InputStreamReader(is, "UTF-8");
>>>
>>> Shouldn't this be cofingurable somehow?
>>>
>>> Best,
>>>
>>> Ernesto
>>>
>>>
>>> On Mon, Sep 28, 2009 at 2:33 AM, Igor Vaynberg <[email protected]
>>> >wrote:
>>>
>>>> all votes are more then welcome.
>>>>
>>>> -igor
>>>>
>>>> On Sun, Sep 27, 2009 at 5:20 PM, Sam Stainsby
>>>> <[email protected]> wrote:
>>>>> Are non-binding votes preferred or discouraged here? If the
>>>>> former, then
>>>>> after some testing with my projects:
>>>>>
>>>>> (nonbinding)
>>>>> [X] Yes release
>>>>> [ ] No, don't release it and here is why...
>>>>>
>>>>>
>>>>
>>>
>
>
>
--
View this message in context:
http://www.nabble.com/-vote--release-1.4.2-tp25636013p25665942.html
Sent from the Wicket - Dev mailing list archive at Nabble.com.
