Hi, Here are the review notes.
When logging in the debug level, check whether debug is enabled. Log the exceptions before throwing. Create Exception class for TransactionManager and throw that, without throwing just Exceptions. Check the concurrent level transactions in data services. Create TransactionManager object per thread. Don't share the same TransactionManager between all tenants. One suggestion for that - move the bindTransactionManager to TransactionManagerAxis2ConfigurationContextObserver and create transactionmanager per thread. when tenants get unloaded clean out the TransactionManagers created (use terminatingConfigurationContext method in TransactionManagerAxis2ConfigurationContextObserver) Add if I have missed the points. Thanks, Lakmali On Thu, May 24, 2012 at 10:08 AM, Dinusha Senanayaka <[email protected]>wrote: > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> > [Data-TG] Code review - Transaction Manager @ Fri May 25 2:00pm - 3:00pm > *When* > Fri May 25 2pm – 3pm Colombo > *Where* > #50 board room (map <http://maps.google.lk/maps?q=%2350+board+room&hl=en>) > *Calendar* > [email protected] > *Who* > • > Dinusha Senanayaka - organizer > • > Sumedha Rubasinghe > • > Shelan Perera > • > [email protected] > • > Prabath Abeysekera > • > Amila Suriarachchi > • > Lakmali Baminiwatta > • > Anjana Fernando > • > Tharindu Mathew > > Going? > ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=1&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=3&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=2&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> > * **more options > »<https://www.google.com/calendar/event?action=VIEW&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- Lakmali Baminiwatta* * Software Engineer WSO2, Inc.: http://wso2.com lean.enterprise.middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
