On Mon, May 28, 2012 at 10:21 PM, Anjana Fernando <[email protected]> wrote:
> Hi, > > On Mon, May 28, 2012 at 4:54 PM, Lakmali Baminiwatta <[email protected]>wrote: > >> Hi, >> >> Here are the review notes. >> >> When logging in the debug level, check whether debug is enabled. >> Log the exceptions before throwing. >> Create Exception class for TransactionManager and throw that, without >> throwing just Exceptions. >> Check the concurrent level transactions in data services. >> Create TransactionManager object per thread. Don't share the same >> TransactionManager between all tenants. >> One suggestion for that - move the bindTransactionManager to >> TransactionManagerAxis2ConfigurationContextObserver and create >> transactionmanager per thread. when tenants get unloaded clean out the >> TransactionManagers created (use terminatingConfigurationContext method in >> TransactionManagerAxis2ConfigurationContextObserver) >> >> Add if I have missed the points. >> > > Be a bit more descriptive of the notes here, like what they actually mean, > and for other recommendations, why they should be done, and any > rationalizations. Like here, what does it mean by "check concurrent level > tranactions??" .. and .. why would we need to create a transaction manager > object per thread?? .. that means . creating a single transaction manager > per request .. I'm not sure why that is necessary .. and it may well be an > expensive operation .. please give a valid reason for it .. every point > should be backed up by some reason .. now I can give an example .. for the > transaction manager usage in Spring framework .. where they use a single > bean to store the transaction manager .. and doesn't create new one for > every new thread .. > Within the code review we saw that same TransactionManager is being used among different services, threads and tenants. Then we raised the question is this thread safe and secure? According to Dinusha and Prabath this code is not test for concurrency. So what we recommend was to first write some test cases to test those scenarios. If that works fine then no problem. thanks, Amila. > > Cheers, > Anjana. > > >> >> Thanks, >> Lakmali >> >> On Thu, May 24, 2012 at 10:08 AM, Dinusha Senanayaka <[email protected]>wrote: >> >>> more details >>> »<https://www.google.com/calendar/event?action=VIEW&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> >>> [Data-TG] Code review - Transaction Manager @ Fri May 25 2:00pm - 3:00pm >>> *When* >>> Fri May 25 2pm – 3pm Colombo >>> *Where* >>> #50 board room (map<http://maps.google.lk/maps?q=%2350+board+room&hl=en> >>> ) >>> *Calendar* >>> [email protected] >>> *Who* >>> • >>> Dinusha Senanayaka - organizer >>> • >>> Sumedha Rubasinghe >>> • >>> Shelan Perera >>> • >>> [email protected] >>> • >>> Prabath Abeysekera >>> • >>> Amila Suriarachchi >>> • >>> Lakmali Baminiwatta >>> • >>> Anjana Fernando >>> • >>> Tharindu Mathew >>> >>> Going? >>> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=1&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en>- >>> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=3&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en>- >>> No<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=2&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> >>> * **more options >>> »<https://www.google.com/calendar/event?action=VIEW&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> >>> >>> Invitation from Google Calendar <https://www.google.com/calendar/> >>> >>> You are receiving this email at the account [email protected] because >>> you are subscribed for invitations on calendar [email protected]. >>> >>> To stop receiving these notifications, please log in to >>> https://www.google.com/calendar/ and change your notification settings >>> for this calendar. >>> >> >> >> >> -- >> Lakmali Baminiwatta* >> * >> Software Engineer >> WSO2, Inc.: http://wso2.com >> lean.enterprise.middleware >> >> > > > -- > *Anjana Fernando* > Associate Technical Lead > WSO2 Inc. | http://wso2.com > lean . enterprise . middleware > -- *Amila Suriarachchi* Software Architect WSO2 Inc. ; http://wso2.com lean . enterprise . middleware phone : +94 71 3082805
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
