Hi Amila, On Tue, May 29, 2012 at 8:11 AM, Amila Suriarachchi <[email protected]> wrote:
> > Within the code review we saw that same TransactionManager is being used > among different services, threads and tenants. > > Then we raised the question is this thread safe and secure? According to > Dinusha and Prabath this code is not test for concurrency. So what we > recommend was to first write some test cases to test those scenarios. If > that works fine then no problem. > +1 for test cases. I got the impression the change was said to be done straight away. I'm guessing the tx manager is keeping the data in thread local variables when a transaction is happening, but better test it / read up on it more and see. Cheers, Anjana. > > thanks, > Amila. > > >> >> Cheers, >> Anjana. >> >> >>> >>> Thanks, >>> Lakmali >>> >>> On Thu, May 24, 2012 at 10:08 AM, Dinusha Senanayaka >>> <[email protected]>wrote: >>> >>>> more details >>>> »<https://www.google.com/calendar/event?action=VIEW&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> >>>> [Data-TG] Code review - Transaction Manager @ Fri May 25 2:00pm - 3:00pm >>>> *When* >>>> Fri May 25 2pm – 3pm Colombo >>>> *Where* >>>> #50 board room (map<http://maps.google.lk/maps?q=%2350+board+room&hl=en> >>>> ) >>>> *Calendar* >>>> [email protected] >>>> *Who* >>>> • >>>> Dinusha Senanayaka - organizer >>>> • >>>> Sumedha Rubasinghe >>>> • >>>> Shelan Perera >>>> • >>>> [email protected] >>>> • >>>> Prabath Abeysekera >>>> • >>>> Amila Suriarachchi >>>> • >>>> Lakmali Baminiwatta >>>> • >>>> Anjana Fernando >>>> • >>>> Tharindu Mathew >>>> >>>> Going? >>>> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=1&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en>- >>>> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=3&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en>- >>>> No<https://www.google.com/calendar/event?action=RESPOND&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&rst=2&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> >>>> * **more options >>>> »<https://www.google.com/calendar/event?action=VIEW&eid=N3RjaGxxNTEzZDRwcjdyN2VpNm9xamFlNDggbGFrbWFsaUB3c28yLmNvbQ&tok=MTYjZGludXNoYUB3c28yLmNvbWVhODg0OWQxYTM0ODZmYWM3MTdlMmFkYjAzOGZiMjM0ODJjMmIzYzI&ctz=Asia/Colombo&hl=en> >>>> >>>> Invitation from Google Calendar <https://www.google.com/calendar/> >>>> >>>> You are receiving this email at the account [email protected] because >>>> you are subscribed for invitations on calendar [email protected]. >>>> >>>> To stop receiving these notifications, please log in to >>>> https://www.google.com/calendar/ and change your notification settings >>>> for this calendar. >>>> >>> >>> >>> >>> -- >>> Lakmali Baminiwatta* >>> * >>> Software Engineer >>> WSO2, Inc.: http://wso2.com >>> lean.enterprise.middleware >>> >>> >> >> >> -- >> *Anjana Fernando* >> Associate Technical Lead >> WSO2 Inc. | http://wso2.com >> lean . enterprise . middleware >> > > > > -- > *Amila Suriarachchi* > > Software Architect > > WSO2 Inc. ; http://wso2.com > lean . enterprise . middleware > > phone : +94 71 3082805 > > -- *Anjana Fernando* Associate Technical Lead WSO2 Inc. | http://wso2.com lean . enterprise . middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
