On Fri, Jan 8, 2016 at 5:42 PM, Sajith Kariyawasam <[email protected]> wrote:
> Hi Raj, > > On Fri, Jan 8, 2016 at 7:30 AM, Rajkumar Rajaratnam <[email protected]> > wrote: > >> Hi Sajith, >> >> No, default.yaml doesn't need to be the exact same configurations of a >> vanilla pack. It represents the "default" profile of a product in a >> deployment. One can update default.yaml and point the carbon db to an >> external MySQL db. He doesn't need to create a new yaml file to be able to >> point the carbon db to an external MySQL db. >> >> As I mentioned earlier (and as Pubuddu agreed), what we should ship in >> default.yaml by default is the exact same configurations of a vanilla pack. >> > > Yes, its the same thing I was talking, from a release point of view we > need to have a default set of configurations (which is the exact same > configs of a vanila pack: pointing to H2 etc ), that's why I was confused > to see config_db / gov / user-mgt related configs in default.xml, which we > don't see in a default carbon master-datasources.xml file. > > Can't we move config/gov/user-mgt datasource configurations [1] into > *common.yaml* ? (And keep the product specific datasources like bps / am > etc in their respective default.yaml) > Because, in a specific setup, values of master-datasources.xml file will > be same in each product, and default.xml file would become more simpler. > > [1] > https://github.com/wso2/puppet-modules/blob/master/hiera/hieradata/dev/wso2/wso2am/1.9.1/default.yaml#L52-L97 > As those are common to all the products IMO we can move them to the common.yaml. No point of duplicating the default hiera values in each product. > > >> Other configurations, such as config/gov db, proxy ports, should be >> commented by default. >> > > Code blocks in [1] too need to be commented out, otherwise it will always > create master-datasources.xml file with all the data sources > > >> >> Thanks, >> Raj. >> >> On Fri, Jan 8, 2016 at 1:25 AM, Sajith Kariyawasam <[email protected]> >> wrote: >> >>> Hi Raj, >>> >>> On Thu, Jan 7, 2016 at 5:40 PM, Rajkumar Rajaratnam <[email protected]> >>> wrote: >>> >>>> >>>> >>>> On Thu, Jan 7, 2016 at 2:31 PM, Chamila De Alwis <[email protected]> >>>> wrote: >>>> >>>>> Hi devs, >>>>> >>>>> In the Hiera files, the default.yaml is supposed to contain values for >>>>> a "default" setup, representing a server running out of the box from a >>>>> downloaded product. Therefore, the wso2::master_datasources should point >>>>> to >>>>> the H2 database. >>>>> >>>> >>>> I guess we are confusing with wordings here. >>>> >>>> default.yaml contains configurations of a product's "default" profile >>>> in a deployment. Similarly manager.yaml is for "manager" profile and so on. >>>> A user can update default.yaml according to their deployment. For example, >>>> he can point carbon db to an external MySQL server. >>>> >>>> I guess you are referring that the gov/config db configurations are >>>> added in some default.yaml and they are pointed to MySQL db. This is >>>> correct, we don't need to point them to H2. What we should do is, we need >>>> to comment these configurations and ship the hiera yaml files. Because >>>> these are not default configurations. >>>> >>> >>> Shouldn't we move wso2_config_db, wso2_gov_db, wso2user_db blocks (which >>> are under wso2::master_datasources), out of default.yaml because those too >>> are not "default" configurations, and move those into worker.yaml and >>> manager.yaml. >>> Shouldn't default.yaml profile equal to the exact same configurations of >>> a fresh pack (with changing values only)? >>> If that's the case why those config_db, gov_db etc defined in >>> default.yaml ? >>> >>> >>>> If a user wants, he can uncomment and modify the settings. For example, >>>> refer [1]. >>>> >>>> [1] >>>> https://github.com/wso2/puppet-modules/blob/master/hiera/hieradata/dev/wso2/wso2am/1.9.1/default.yaml#L11-L33 >>>> >>>> Thanks, >>>> Raj. >>>> >>>> >>>>> However, the default.yaml contains datasources pointing to a MySQL >>>>> server. IMO this should change to point to the H2 database. WDYT? >>>>> >>>>> Regards, >>>>> Chamila de Alwis >>>>> Committer and PMC Member - Apache Stratos >>>>> Software Engineer | WSO2 | +94772207163 >>>>> Blog: code.chamiladealwis.com >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Rajkumar Rajaratnam >>>> Committer & PMC Member, Apache Stratos >>>> Software Engineer, WSO2 >>>> >>>> Mobile : +94777568639 >>>> Blog : rajkumarr.com >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Sajith Kariyawasam >>> *Committer and PMC member, Apache Stratos, * >>> *WSO2 Inc.; http://wso2.com <http://wso2.com>* >>> *Mobile: 0772269575* >>> >> >> >> >> -- >> Rajkumar Rajaratnam >> Committer & PMC Member, Apache Stratos >> Software Engineer, WSO2 >> >> Mobile : +94777568639 >> Blog : rajkumarr.com >> > > > > -- > Sajith Kariyawasam > *Committer and PMC member, Apache Stratos, * > *WSO2 Inc.; http://wso2.com <http://wso2.com>* > *Mobile: 0772269575* > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Gayan Gunarathne Technical Lead, WSO2 Inc. (http://wso2.com) Committer & PMC Member, Apache Stratos email : [email protected] | mobile : +94 775030545 <%2B94%20766819985>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
