I do favor packaging tests with sources. Almost anyone who is building from source will appreciate being able to confirm the build was clean (or as clean as we know to test for). Tests should definitely be a separate jar and/or an optional part of the build, though; no reason to ship them with production code.
I don't remember anything in the build that would make porting to another build platform particularly difficult, but it's been a long time and Maven is one I haven't looked closely at) -- /_ Joe Kesselman (he/him/his) -/ _) My Alexa skill for New Music/New Sounds fans: / https://www.amazon.com/dp/B09WJ3H657/ () Plaintext Ribbon Campaign /\ Stamp out HTML mail! ________________________________ From: Gary D. Gregory <ggreg...@apache.org> Sent: Monday, October 31, 2022, 11:09 AM To: dev@xalan.apache.org <dev@xalan.apache.org> Subject: Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC5 Hi Mukul, It does not feel like a good idea to exclude tests from the src zip/tars. This is most likely due to our use of Ant; this would not be an issue with Maven obviously, since it packages tests in a test jar and in sources, at least in the way we use Maven in other projects (Commons for example). Since we deliver sources, it seems reasonable to deliver tests to support the use case where a user or Linux distro wants to build from scratch and use git: - Download src zip or tar - Possibly edit sources for reason X or to fix a bug - Test and Build - "Release" internally to the users dist system (or not) WDYT? It might even be worth porting the build to Maven at this point. Gary On 2022/10/31 04:26:15 Mukul Gandhi wrote: > Hi Gary, > The XalanJ tests (like the "sometest"), are not intended to be run > from the XalanJ functional codebase build (i.e, from the repos > xalan-java. That's what you're trying to do I guess). Instead XalanJ > tests, are to be run from the repos xalan-test. > > We had earlier, described the process, to run XalanJ tests within the > file README on the repos xalan-java (branch xalan-j_2_7_1_maint). That > works fine for me, to run the XalanJ tests. The location of, this > README file is > https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint. > > On Sun, Oct 30, 2022 at 8:50 PM Gary Gregory <garydgreg...@gmail.com> wrote: > > > When I unzip the src zip and run 'ant smoketest' I get: > > > > ... > > jar: > > > > smoketest-run: > > [echo] [minitest] Calling ../test/build.xml to run the Smoketest > > > > BUILD FAILED > > /Users/garydgregory/Downloads/xalan-j_2_7_3/build.xml:1507: The following > > error occurred while executing this line: > > Error reading project file /Users/garydgregory/Downloads/test/build.xml: > > /Users/garydgregory/Downloads/test/build.xml > > > > Gary > > > -- > Regards, > Mukul Gandhi > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org > For additional commands, e-mail: dev-h...@xalan.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
