Given that these are still unannounced, unreleased, and unsupported
prototypes, putting them into CI seems premature to me...?
On 5/29/2023 1:21 PM, Vladimir Sitnikov wrote:
> I've committed today a working junit test suite, for XalanJ XSLT
Adding tests is great.
I see the tests have a lot of repetitions like "prepare transformer,
run thansformation, verify results". I wonder if you considered a
possibility to factor the repeating code. It would make the tests
easier to read.
I see the tests are named like test1, test2, test3, and so on. Have
you considered selecting human-readable test names? I guess it would
make the code easier to review, and the test failures easier to analyze.
Could you please clarify if you execute the tests in CI? It is good
there are some tests, however it is not clear if they pass or fail.
Vladimir
--
Vladimir
