Hi Vladimir, On Mon, May 29, 2023 at 10:52 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote:
> I see the tests have a lot of repetitions like "prepare transformer, run transformation, verify results". I believe that, this pattern to run all the tests available within a file like "AnalyzeStringTests" (this is one of the files, that is available within this junit test suite) is necessary. Every test method like test1(), has its own specific .xsl (that needs to be prepared corresponding to its unique XSLT javax.xml.transform.Transformer object) document. The test method like test1() then has to invoke method xslTransformer.transform(... to run the XSLT transformation, after which the result of this XSLT transformation may be compared to an expected XSLT transformation output. > I see the tests are named like test1, test2, test3, and so on. Have you considered selecting human-readable test names? I guess it would make the code easier to review, and the test failures easier to analyze. If you're really interested to review these XSLT transformation tests that I've provided, then test names like test1, test2 ... shouldn't matter. I've personally, found this naming convention for these tests, easier to convert to a workable junit test suite. You may need to look at the XSLT syntax within each of the .xsl files provided, and review whether the mentioned XSLT syntax is correct and produces the intended XSLT transformation result. > Could you please clarify if you execute the tests in CI? It is good there are some tests, however it is not clear if they pass or fail. Joseph has already answered that, XalanJ project CI configuration for these tests, is still premature to create, and I do agree with him. For your reference, below is an inline screen paste of the junit tests results (that I've run from within Java eclipse ide) of all these XalanJ tests that're provided, [image: xalanj_junit_tests_status.png] -- Regards, Mukul Gandhi
