Hi Vladimir,
Thanks for the thoughts.
I'll try to answer, few of your questions within another thread than
this, if I feel that I could add value to those points.
In the meantime, I'd like to share that, I've committed few XalanJ
tests codebase changes, as per my comments inline below,
On Tue, May 30, 2023 at 11:12 AM Vladimir Sitnikov
<sitnikov.vladi...@gmail.com> wrote:
> Selecting method names, variable names, and class names helps readers to
> understand the intention behind the code.
> However, the code with "test1, test2, tets3" methods takes more time to
> understand than a code with reasonable names.
This has been implemented as per your suggestions, and has been
committed to xalan-java repos.
> Factoring common code helps to prevent copy-pasting the same errors into many
> classes.
>
> public static void runTransformAndAssertOutput(File xmlFilePath, File
> xlsFilePath, File goldFilePath) {
> try {
> Node xmlDomSource = docBuilder.parse(new InputSource(xmlFilePath));
>
> Transformer xslTransformer = tfactory.newTransformer(new
> StreamSource(xslFilePath));
> StringWriter resultStrWriter = new StringWriter();
> xslTransformer.transform(new DOMSource(xmlDomSource), new
> StreamResult(resultStrWriter));
>
> byte[] goldFileBytes = Files.readAllBytes(Paths.get(goldFilePath));
>
> Assert.assertEquals(new String(goldFileBytes),
> resultStrWriter.toString());
> }
> catch (Exception ex) {
> Assert.fail();
> }
> }
Such a XalanJ tests code refactoring has also been implemented as per
your suggestions, and has been committed to xalan-java repos.
You may review these changes, that're now available at :
https://github.com/apache/xalan-java/tree/xalan-j_xslt3.0/tests/org/apache/xalan.
Many thanks, for all your suggestions.
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
